Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Minimum font size setting or set to 0 as default #5510

Open
simefield opened this issue Aug 2, 2019 · 7 comments
Open

Remove Minimum font size setting or set to 0 as default #5510

simefield opened this issue Aug 2, 2019 · 7 comments
Labels
accessibility needs-investigation A bug not 100% confirmed/fixed

Comments

@simefield
Copy link

Description

Brave's arbitrary Minimum font size setting breaks modern layouts and is does not achieve what it sets out to do.
Setting a root-em of less than Brave's default will be over-ridden, but sometimes it is desirable, especially in modern development to use the root-em to achieve vertical rhythm in ones design. Over-riding this breaks well designed layouts.
Furthermore, setting a minimum of 6 pixels is plain stupid anyway, as even at that size text in illegible. You might as well set it at 16 pixels if you are wanting to take the power away from designers and put it into users who are unable to increase their page zoom / font sizes.
Brave should not be broadly over-riding good designer's work because of some bad designers out there. Websites with illegibly tiny fonts will suffer and die naturally.

Steps to Reproduce

  1. In your CSS, on the root element (html or :root) set the font-size to 4px
  2. Observe: Brave changes this to 6px by default

Actual result:

Setting an element to have padding: 4rem will result in padding: 24px.

Expected result:

Expected result is padding: 16px

Reproduces how often:

Easily reproduced.

Brave version (brave://version info)

Brave 0.66.100 Chromium: 75.0.3770.142 (Official Build) (64-bit)
Revision 8d93477bd18154c67a70a67019cb8032382c55dd-refs/branch-heads/3770@{#1160}
OS Mac OS X

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yep
  • Can you reproduce this issue with the beta channel? Dunno
  • Can you reproduce this issue with the dev channel? Dunno
  • Can you reproduce this issue with the nightly channel? Dunno

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? Nope
  • Does the issue resolve itself when disabling Brave Rewards? Nope
  • Is the issue reproducible on the latest version of Chrome? Dunno

Miscellaneous Information:

@kjozwiak kjozwiak added needs-investigation A bug not 100% confirmed/fixed repros-on-chrome labels Aug 2, 2019
@bsclifton
Copy link
Member

bsclifton commented Aug 2, 2019

cc: @bradleyrichter (this should also be happening in Chrome)

@simefield
Copy link
Author

Negative. This is not an issue in Chrome, but was implemented in Brave. See: https://community.brave.com/t/desperately-needs-a-minimum-font-size-feature/14983

@bradleyrichter
Copy link

The UI control allows 0 but it seems to be ignored, ni both Brave and Chrome, on Mac OS at least.

image

@bsclifton we should allow zero (or 1 if required for a technical minimum)

@rebron
Copy link
Collaborator

rebron commented Aug 16, 2019

@simefield Do you have an example website or web page handy? If not, we'll go ahead and write a simple test case for it.

@simefield
Copy link
Author

Here's an example: https://codepen.io/simefield/pen/YzKWgZG
The space between the two grey border lines is 8 pixels in Chrome and other browsers, but observe this becomes 12 pixels in Brave because of the offending setting.

I also think my point is being missed. This setting should not exist at all. There should be no minimum default font size setting. At least, not one that affects the base REM size. For starters, having a minimum font size of 6 pixels is pointless, as—if anyone ever designed a site with 5px text—such poorly implemented text would still remain illegible at 6px regardless. Can anyone give me a use case where a setting of 6 pixels solves an issue? And if it solves nothing, but causes layout issues, surely we it should be removed from the browser's settings.

@andr222
Copy link

andr222 commented Aug 18, 2019

I also think my point is being missed. This setting should not exist at all. There should be no minimum default font size setting. At least, not one that affects the base REM size. For starters, having a minimum font size of 6 pixels is pointless, as—if anyone ever designed a site with 5px text—such poorly implemented text would still remain illegible at 6px regardless. Can anyone give me a use case where a setting of 6 pixels solves an issue? And if it solves nothing, but causes layout issues, surely we it should be removed from the browser's settings.

If the choice is between readable and possible layout problems, the answer should be clear.
Some users can't read smaller type, so they need such a setting. Others would be happy with a 6 pixel minimum, which seems to be a reasonable default. (That is the default in some other browsers)
If it isn't working properly, it needs to be fixed

@yisibl
Copy link

yisibl commented Apr 1, 2024

Chrome 118 started to tweak the minimum font size limit, see: https://chromestatus.com/feature/5150487577362432

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility needs-investigation A bug not 100% confirmed/fixed
Projects
None yet
Development

No branches or pull requests

7 participants