Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor BraveRequestHandler #5574

Open
iefremov opened this issue Aug 7, 2019 · 0 comments
Open

Refactor BraveRequestHandler #5574

iefremov opened this issue Aug 7, 2019 · 0 comments
Assignees
@iefremov
Labels
dev-concern
Projects
Chromium Rebasing Ivan's board

Comments

@iefremov
Copy link
Contributor

iefremov commented Aug 7, 2019 •
edited

  1. BraveRequestHandler inherited its architecture from BraveNetworkDelegate - with different sorts of callbacks that are stored in different containers. We should unify all callbacks, put them into a single container and iterate over it.

  2. Get rid of shared_ptr<>

  3. Minimize amount of data in BraveRequestInfo and try to make it immutable
@iefremov iefremov self-assigned this Aug 7, 2019
@iefremov iefremov mentioned this issue Aug 7, 2019
Merged
32 tasks
@bsclifton bsclifton added this to Needs triage in Chromium Rebasing via automation Feb 20, 2020
@iefremov iefremov mentioned this issue May 17, 2021
Closed
@iefremov iefremov added this to To Do in Ivan's board via automation May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iefremov iefremov

Labels
dev-concern
Projects
Chromium Rebasing
  
Needs triage
Ivan's board
To Do
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iefremov @rebron