Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Tab background is cropped when vertical scrollbar is visible #5844

Closed
btlechowski opened this issue Aug 30, 2019 · 8 comments
Closed

New Tab background is cropped when vertical scrollbar is visible #5844

btlechowski opened this issue Aug 30, 2019 · 8 comments

Comments

@btlechowski
Copy link

btlechowski commented Aug 30, 2019

Steps to Reproduce

  1. Open new tab
  2. Resize browser window so that vertical scrollbar is visible
  3. Scroll down

Actual result:

The background is cropped at the bottom
image
Sometimes the settings icons are not visible
image

Expected result:

The background is not cropped

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 0.71.44 Chromium: 76.0.3809.132 (Official Build) nightly (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Windows 7 Service Pack 1 (Build 7601.24511)
Brave 0.70.78 Chromium: 76.0.3809.132 (Official Build) dev (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Windows 7 Service Pack 1 (Build 7601.24511)

cc @brave/legacy_qa @cezaraugusto @imptrx

@btlechowski
Copy link
Author

Also reproducible on beta and release, but only the background overlay is cropped

Brave 0.68.132 Chromium: 76.0.3809.132 (Official Build) (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Windows 7 Service Pack 1 (Build 7601.24511)
Brave 0.69.119 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Windows 7 Service Pack 1 (Build 7601.24494)

image

cc @bsclifton @rebron

@btlechowski
Copy link
Author

Reproducible on Ubuntu 18.04

Brave 0.69.121 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Ubuntu 18.04 LTS

image

Brave 0.71.35 Chromium: 76.0.3809.100 (Official Build) nightly (64-bit)
Revision ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS Ubuntu 18.04 LTS

image

@rebron rebron added this to Untriaged backlog in New Tab page Sep 3, 2019
@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label Sep 6, 2019
@rebron rebron moved this from Untriaged backlog to P4 backlog in New Tab page Sep 6, 2019
@BlakeJanes
Copy link

I'd like to take a crack at fixing this issue.

@btlechowski
Copy link
Author

@BlakeJanes That's awesome!

If you have any questions, don't hesitate to ask.
I assigned the issue to you. If you decide not to proceed just unsigned yourself.

Good luck!

@bsclifton
Copy link
Member

cc: @cezaraugusto who may be able to provide guidance 😄 Although not merged yet, I have some contributor guidelines which may help you get started with things
#6265

@karenkliu
Copy link

Does this issue still apply to current images?

@btlechowski
Copy link
Author

No longer reproducible in 0.71.x and above. Closing the issue.
Added it to 0.71.x so that it can be checked on all platforms.

@btlechowski btlechowski added this to the 0.71.x - Release milestone Nov 7, 2019
@btlechowski
Copy link
Author

btlechowski commented Nov 7, 2019

Verification passed on

Brave 0.71.111 Chromium: 78.0.3904.87 (Official Build) (64-bit)
Revision 20c21f4010010f32462ea8e1d6af30cef66d48c8-refs/branch-heads/3904@{#840}
OS Ubuntu 18.04 LTS

Verified STR from the description.

image

Verification passed on

Brave 0.71.112 Chromium: 78.0.3904.87 (Official Build) beta (64-bit)
Revision 20c21f4010010f32462ea8e1d6af30cef66d48c8-refs/branch-heads/3904@{#840}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified STR from the description.
    Light mode:
    image

image

Dark mode:

image

Verified passed with

Brave 0.71.112 Chromium: 78.0.3904.87 (Official Build) beta (64-bit)
Revision 20c21f4010010f32462ea8e1d6af30cef66d48c8-refs/branch-heads/3904@{#840}
OS macOS Version 10.13.6 (Build 17G5019)
  • Verified STR from description

Screen Shot 2019-11-08 at 10 37 43 AM

Screen Shot 2019-11-08 at 10 38 12 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants