Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save Dialog Filter Doesn't Display All Jpeg Files #6871

Closed
cwmke opened this issue Nov 11, 2019 · 1 comment
Closed

Save Dialog Filter Doesn't Display All Jpeg Files #6871

cwmke opened this issue Nov 11, 2019 · 1 comment
Labels
Chromium/waiting upstream Issue is in Chromium; we'll likely wait for the fix closed/wontfix shell-integration

Comments

@cwmke
Copy link

cwmke commented Nov 11, 2019

Description

When saving images, already saved .jpg files are not shown by default. Only .jpeg files are visible.

Steps to Reproduce

  1. Right click on an image and click 'save image as...'
  2. Dialog pops up with the '*.jpeg' filter' (if the image is a .jpeg file)

Actual result:

Must switch to 'All Files' filter to view .jpg files. The same happens in reverse with saving .jpg files.

Expected result:

Whether the extension is .jpg or .jpeg, the filter should show both as they are the same type of file.

Reproduces how often:

Easily reproduced. Duckduckgo's image search is a good place to find .jpeg files. Wikipedia has some .jpg.

Brave version (brave://version info)

Brave 0.70.122 Chromium: 78.0.3904.87 (Official Build) (64-bit)
Revision 20c21f4010010f32462ea8e1d6af30cef66d48c8-refs/branch-heads/3904@{#840}
OS Linux

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? No
  • Does the issue resolve itself when disabling Brave Rewards? No
  • Is the issue reproducible on the latest version of Chrome? Unknown

Miscellaneous Information:

@bsclifton
Copy link
Member

bsclifton commented Dec 31, 2019

Reproduced on Linux and Windows (may happen on macOS too; didn't check)

If GTK (specifically, with GtkFileChooserDialog) supports multiple file extensions (like I know Win32 does, with GetSaveFileName), we could possibly patch Chromium (or fix upstream) to add custom code to look at .jpeg extensions and manually change them to *.jpg,*.jpeg, but I don't think that would be a good idea

I'm going to close this and suggest we open a bug in Chromium instead:
https://bugs.chromium.org/p/chromium/issues/list

I didn't find any existing (open or closed) issues for this in the Chromium issue log, but I suspect it would be closed as a wontfix

@bsclifton bsclifton added Chromium/waiting upstream Issue is in Chromium; we'll likely wait for the fix closed/wontfix labels Dec 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chromium/waiting upstream Issue is in Chromium; we'll likely wait for the fix closed/wontfix shell-integration
Projects
None yet
Development

No branches or pull requests

2 participants