Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updatePatches should ignore Android XML files that we override #7700

Open
emerick opened this issue Jan 10, 2020 · 1 comment
Open

updatePatches should ignore Android XML files that we override #7700

emerick opened this issue Jan 10, 2020 · 1 comment
Labels
dev-concern OS/Android Fixes related to Android browser functionality

Comments

@emerick
Copy link
Contributor

emerick commented Jan 10, 2020

We sometimes have the need to completely override an XML file in our Android builds. You can easily do this by creating the same file in brave/android/java/res/, however updatePatches will consider the file to be a patched. We should modify updatePatches to ignore changes to those files, as we don't want to accidentally commit them.
@emerick
Copy link
Contributor Author

emerick commented Jan 10, 2020

cc: @bridiver, this came up while working on brave/brave-core#4360

@rebron rebron added android-core-release OS/Android Fixes related to Android browser functionality dev-concern and removed android-core-release labels Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dev-concern OS/Android Fixes related to Android browser functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@emerick @rebron