Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URL fixup code doesn't recognise brave scheme #8045

Open
jonathanKingston opened this issue Feb 4, 2020 · 0 comments
Open

URL fixup code doesn't recognise brave scheme #8045

jonathanKingston opened this issue Feb 4, 2020 · 0 comments
Labels
feature/autocomplete feature/url-bar priority/P5 Not scheduled. Don't anticipate work on this any time soon.
Projects
Front End

Comments

@jonathanKingston
Copy link

After looking into #2951 I realised that brave wasn't working in the URL bar due to the Fixup code within chromium doesn't allow list the brave scheme causing it to always be treated as search.

url_formatter::FixupURL() is the code that needs to be modified to make this work.
@jonathanKingston jonathanKingston mentioned this issue Feb 6, 2020
Closed
32 tasks
@rebron rebron added feature/url-bar feature/autocomplete priority/P5 Not scheduled. Don't anticipate work on this any time soon. labels Mar 27, 2020
@rebron rebron added this to P5 backlog in Front End Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature/autocomplete feature/url-bar priority/P5 Not scheduled. Don't anticipate work on this any time soon.
Projects
Front End
Status: P5 backlog
Front End
  
P5 backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonathanKingston @rebron