Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to pin tabs to all windows / new windows #8558

Open
triqi opened this issue Mar 5, 2020 · 5 comments
Open

Ability to pin tabs to all windows / new windows #8558

triqi opened this issue Mar 5, 2020 · 5 comments
Labels
feature/pinned-tabs feature-request needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. priority/P5 Not scheduled. Don't anticipate work on this any time soon.
Projects

Comments

@triqi
Copy link

triqi commented Mar 5, 2020

Updated issue description (@bsclifton)

Maybe we can expose a setting allowing pinned tabs to persist across all windows (including new windows)

Original issue description

When starting Brave, I get a new window (assuming I only have one profile) and a default tab. I navigate to a URI and pin the tab. When I close that window (using the cross on the window header) and open a new one (from the file menu), my pinned tab is not restored. The only way to have pinned tabs restored is on app quit (hard exit with Cmd + Q).

Steps to Reproduce

  1. Start Brave and pin a tab on any URI.
  2. Close the window by clicking on the cross on the window header.
  3. Open a new window from the top menu.

Actual result:

New windows do not restore pinned tabs.

Expected result:

All new windows should restore pinned tabs.

Reproduces how often:

Every time the steps are followed.

Brave version (brave://version info)

Version 1.4.96 Chromium: 80.0.3987.132 (Official Build) (64-bit)

Other Additional Information:

macOS Catalina 10.15.03

@piotrfonte
Copy link

I suspect this is not a bug report but a feature request. Either way… I’d love to see this implemented!

@bsclifton bsclifton changed the title Pinned tabs are not restored when closing the window [Mac OS] Ability to pin tabs to all windows / new windows Mar 19, 2020
@bsclifton
Copy link
Member

bsclifton commented Mar 19, 2020

Thanks for the feedback @triqi @PiotrF!

This is indeed a feature request; I updated issue title and added a note to original post to help us triage it

@rebron rebron added the needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. label Apr 17, 2020
@rebron
Copy link
Collaborator

rebron commented Apr 17, 2020

I suspect this would need to be a pref if done at all, since the expectation by default would be new window = new window, not new window + pinned tabbeds from previous window.

It gets compllcated when you have two windows with different pinned tabs. What's the expectation for the third window? How would we order what the pinned tabs are from the previous two windows, in that third window?

@rebron rebron added this to Untriaged backlog in Front End Apr 20, 2020
@rebron rebron added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Apr 24, 2020
@rebron rebron moved this from Untriaged backlog to P5 backlog in Front End Jun 2, 2020
@piotrfonte
Copy link

I think Safari on Mac OS could be an example to consider. I love how I can have different tabs pinned for things I use frequently.

@jrkager
Copy link

jrkager commented May 31, 2023

Any update on this feature request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/pinned-tabs feature-request needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. priority/P5 Not scheduled. Don't anticipate work on this any time soon.
Projects
Status: P5 backlog
Front End
  
P5 backlog
Development

No branches or pull requests

5 participants