Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brave-installer not available for release 1.5.112 #8743

Closed
crazy-max opened this issue Mar 18, 2020 · 15 comments
Closed

brave-installer not available for release 1.5.112 #8743

crazy-max opened this issue Mar 18, 2020 · 15 comments

Comments

@crazy-max
Copy link

Hi,

brave-installer-ia32.exe and brave-installer-x64.exe are not available for release v1.5.112.
Is it on purpose? Because these artifacts are required for Brave portable

Thanks

@akash07k
Copy link

Yes, I too am noticing the same. if it is by purpose, then please let us know the reason?

@bsclifton
Copy link
Member

cc: @mihaiplesa @mbacchi @linhkikuchi do we still upload these? (or should we)

I think the Standalone ones should work too

@mbacchi
Copy link
Contributor

mbacchi commented Mar 19, 2020

We have stopped uploading these to the Github releases in order to prevent issues like this where users inadvertently install the brave-installer executable without a tag and therefore become stuck on that single version and never get updated because the tag doesn't match what is used on our update server.

There are multiple other installation options so this shouldn't be required for standard installation support.

@mbacchi mbacchi closed this as completed Mar 19, 2020
@crazy-max
Copy link
Author

crazy-max commented Mar 21, 2020

I think the Standalone ones should work too

@bsclifton Unfortunately Standalone setups cannot be extracted programmatically so this is not an option for Brave portable.

...to prevent issues like this where...

@mbacchi This issue points to a private repo I think. Can you tell me more about this issue here?

@mbacchi
Copy link
Contributor

mbacchi commented Mar 21, 2020

I updated the issue that I linked to above. It was related to the tag for the installer not being set.

@crazy-max
Copy link
Author

crazy-max commented Mar 21, 2020

@mbacchi Hmmm I don't see anything about the removal of brave-installer-ia32.exe and brave-installer-x64.exe artifacts in #2221. And this also concerns Brave 0.56.14 and the artifacts have been removed since 1.5.x so...
Can you enlighten me please?

@mbacchi
Copy link
Contributor

mbacchi commented Mar 21, 2020

Issue #2221 was simply an example, our plan has been to discontinue distributing the brave-installer-*.exe files for quite a while, in order to prevent situations where users installed that raw executable and were never able to update automatically. Sorry if this inconveniences you.

@LazyZhu
Copy link

LazyZhu commented Mar 22, 2020

Even corp like Google does provide extractable none-updated version of chrome.
BraveBrowser is becoming another product like Waterfox, become famous, acquired by big corp, etc.

@crazy-max
Check Ungoogled-Chromium
https://github.com/macchrome/winchrome/releases

@crazy-max
Copy link
Author

crazy-max commented Mar 25, 2020

@mbacchi As @LazyZhu rightly says, these installers are also available for Chrome. For me this is the responsibility of the user. I find it very radical and regressive that your team simply prefers to remove these artifacts.

@bsclifton
Copy link
Member

@mbacchi could we re-add these with a name that makes it obvious it shouldn't be used by regular users? and/or update the text that gets automatically put onto the release page? Could be something like Brave-Browser-Win32.7z (rather than uploading the .exe ending)

@bsclifton
Copy link
Member

bsclifton commented Mar 25, 2020

re-opening as examples have been provided where the files are provided by other projects

@mihaiplesa
Copy link
Contributor

@crazy-max working on a fix for you now.

@akash07k
Copy link

@crazy-max working on a fix for you now.

Thanks in advance for the willingness to provide the fix.

@mihaiplesa
Copy link
Contributor

mihaiplesa commented Mar 25, 2020

Here goes:

https://brave-browser-downloads.s3.brave.com/latest/brave_installer-x64.exe
https://brave-browser-downloads.s3.brave.com/latest/brave_installer-ia32.exe

These will always be the latest stable version.

@crazy-max thanks for your work on the portable version and if you're interested in verifying your GitHub profile at https://creators.brave.com/ you can earn BAT tips from the community.

@crazy-max
Copy link
Author

@mihaiplesa Great! Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants