Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up of #8781 - Pinned sites are being duplicated after upgrade #9299

Closed
GeetaSarvadnya opened this issue Apr 17, 2020 · 4 comments
Closed

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Apr 17, 2020

Description

Follow up of #8781 - Pinned sites are being duplicated after upgrade

Steps to Reproduce

  1. Clen profile 1.7.x
  2. Open 6 different sites
  3. Pin 3 sites in NTP keep reaming 3 sites as it is
  4. Upgrade to 1.8.x
  5. On the existing NTP, 3 pinned tabs and remaining 3 unpinned tabs are shown correctly
  6. Open a NTP
  7. Out of 6 sites, 3 Pinned sites are duplicated and remaining 3 sites are lost in 1.8.x

Note: The issue is reproducible in both 1.7.92 and 1.7.95

Actual result:

3 Pinned sites are duplicated and remaining 3 sites are lost in 1.8.x

Before upgrade 1.7.x
image
After upgrade to 1.8.x
image

Expected result:

Pinned tabs and all other tabs remain the same after upgrade

Reproduces how often:

Always

Brave version (brave://version info)

Brave 1.8.77 Chromium: 81.0.4044.92 (Official Build) dev (64-bit)
Revision e98e6f21168a55e7ba57202f56323911cd9d31d1-refs/branch-heads/4044@{#883}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Not sure
  • Can you reproduce this issue with the beta channel? Not sure
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Not sure

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @cezaraugusto @rebron

@GeetaSarvadnya
Copy link
Author

Before upgrade in 1.7.92

image

After upgrade to 1.8.x
image

@bsclifton
Copy link
Member

cc: @cezaraugusto - may be related to the fix you did for top site migration ☹️

@cezaraugusto
Copy link
Contributor

@bsclifton this is fixed but needs uplift. brave/brave-core#5219

@bsclifton
Copy link
Member

Closing as duplicate of #9008 😄

@bsclifton bsclifton added the closed/duplicate Issue has already been reported label Apr 22, 2020
@bsclifton bsclifton removed this from the 1.8.x - Release milestone Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants