Skip to content
This repository has been archived by the owner on Mar 25, 2024. It is now read-only.

Buy/Send/Swap not opening from Asset Details #8776

Closed
soner-yuksel opened this issue Feb 28, 2024 · 3 comments
Closed

Buy/Send/Swap not opening from Asset Details #8776

soner-yuksel opened this issue Feb 28, 2024 · 3 comments

Comments

@soner-yuksel
Copy link
Member

Description:

Buy, send and swap are not opening for some assets when tapped in Asset Details. The bug seems to occur on any asset with no account balance.

Steps to Reproduce

  1. Open Wallet
  2. Scroll Portfolio to find ETH on Optimism.
    • Seems to occur on any asset where user does not have any account balance
  3. Tap 'Buy'
  4. Observe buy does not open
    • Buy/send/swap do not open either
    • Some other assets do open as expected. Needs investigation.

Actual result:

Asset.Details.MP4

Expected result:

Reproduces how often: [Easily reproduced, Intermittent Issue]

Easily reproduced with ETH on Optimism, not all assets failing to open.

Brave Version:

v1.62 App Store

  • Can you reproduce this issue with the most recent build from TestFlight?
  • Can you reproduce this issue with the previous version of the current build from TestFlight?
  • Can you reproduce this issue with the current build from AppStore?

Device details:

iPhone 14 Pro iOS 17.3.1

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Mobile Safari?

Additional Information

Community report:
https://community.brave.com/t/i-cannot-send-or-swap-crypto/532738/3

@soner-yuksel
Copy link
Member Author

This ticket is copy of brave/brave-browser#36266. It is created by the request of Quality Assurance team for tracking purposes of hotfix.

@kjozwiak kjozwiak mentioned this issue Feb 28, 2024
4 tasks
@kjozwiak
Copy link
Member

kjozwiak commented Feb 28, 2024

Thanks @soner-yuksel 👍 Labelling brave/brave-browser#36266 as QA/No and release-notes/exclude as it will be verified via 1.62.1 using the brave-ios repo. @srirambv also verified the issue via master using the brave-core repo as per brave/brave-core#22229 (comment). Also closing #8774 as a duplicate as we decided to include the fix in the 1.62.1 HF.

@srirambv
Copy link
Contributor

Verification passed on iPhone 13 with iOS 17.4 running 1.62.1 (24.2.28.21)

  • Verified steps from brave/brave-core#22229
  • Verified Buy/Send/Swap buttons work as expected and loads correct screen when opened from asset details screen
36266.MP4

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants