Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Intermittently bringing brave up from being minimized causes the pin window to show with no number pad. #980

Closed
gortok opened this issue Mar 16, 2019 · 4 comments

Comments

@gortok
Copy link

gortok commented Mar 16, 2019

Description:

Hard to reproduce but regularly brave will come up from being minimized with no numberpad showing on the passcode screen.

Steps to Reproduce

  1. Use brave.
  2. Minimize it.
  3. Bring it back up via its icon, note that no number pad shows. Only way to correct is force quit brave.

Actual result:
1410A816-4412-4A85-A73E-510D12722DB1

Expected result:

Expect number pad to come up when passcode window comes up.
Reproduces how often: [Easily reproduced, Intermittent Issue]
Intermittent. Can not reliably reproduce but it does happen regularly.

Brave Version:
1.8

Device details:
iPhone 12.1.4

Additional Information

@kjozwiak
Copy link
Member

@jhreis should this be removed from the 1.10 milestone or are we planning on fixing this? I don't see a release associated with this one on ZenHub either.

@kjozwiak kjozwiak modified the milestones: 1.10, 1.11 Jul 22, 2019
@jhreis
Copy link
Contributor

jhreis commented Jul 23, 2019

Related: #1122

@jhreis
Copy link
Contributor

jhreis commented Jul 23, 2019

Regardless of the solution here, we should also make the keyboard present on clicking on the UI somewhere, see #1122 for related notes.

@srirambv
Copy link
Contributor

srirambv commented Sep 6, 2019

Verification passed on iPhone XR with iOS 13.1 beta 2 running 1.12(19.09.05.20)

  • Verified pin window show up with keyboard when the app is launched for the first time
  • Verified pin window show up with keyboard when the app is launched from background
  • Verified pin window show up with keyboard when the device is unlocked with Brave as the active app
  • Verified pin window show up with keyboard when app swipe to bring Brave app as active

Verification PASSED on iPad Air 3rd Generation iOS 13.1 running 1.12 (19.09.11.15):

  • Verified pin window show up with keyboard when the app is launched for the first time
  • Verified pin window show up with keyboard when the app is launched from background
  • Verified pin window show up with keyboard when the device is unlocked with Brave as the active app
  • Verified pin window show up with keyboard when app swipe to bring Brave app as active

Verification PASSED on iPhone 6s+ using iOS 12.4.1 running 1.12 (19.09.13.06):

  • Verified pin window show up with keyboard when the app is launched for the first time
  • Verified pin window show up with keyboard when the app is launched from background
  • Verified pin window show up with keyboard when the device is unlocked with Brave as the active app
  • Verified pin window show up with keyboard when app swipe to bring Brave app as active

@jhreis jhreis added the Epic: Pincode Epic for defining issues pertaining to the iOS pincode / passcode lock. label Jan 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants