Publisher Ads support for initial test sites #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petemill
force-pushed
the
pub-ads
branch
2 times, most recently
from
3a74c64
to
dadcde2
Compare
- Individual ad-slot detection strategy for each site, with some shared utilities - Shared one-best-on-page Slot Filtering strategy - Rendering of a BatAd via shadow DOM - Fetching of ad creative via communication with Brave extension (TODO: change to chrome.braveRewards call)
…king on ad, and hide category if no category data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
chrome.braveRewards, once the API exists in brave-core