Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No option to go to premium page when trying to start a web3 call without premium account #821

Closed
srirambv opened this issue Apr 21, 2023 · 9 comments
Assignees

Comments

@srirambv
Copy link
Collaborator

Description

No option to go to premium page when trying to start a web3 call without premium account

Steps

  1. Clean profile
  2. Restore wallet which has NFTs/POAPs
  3. Visit https://talk.brave.software and click on Start a Web3 Call
  4. Sign wallet access request
  5. Select NFTs/POAPs listed
  6. Click on Start 1:1 Web3 call
  7. Shows Sorry, you are not a subscriber but nothing more
  8. Console shows Web3 Calls Require Brave Talk Premium Subscription

Actual Result

image

Expected Result

Probably better to show the response message on the page and have a link for https://account.brave.com/ to navigate for subscription

Additional info

cc: @mrose17

@mrose17
Copy link
Member

mrose17 commented Apr 21, 2023

@johnhalbert - this is the same as item 7 in my TODO list -- #821 -- i'll remove it in favor of this issue.

@mattmcalister
Copy link

image

Intro copy: Create a Web3 video call with token-gated access controls. Select a unique NFT avatar, assign moderator privileges using POAPs, and more.

Button: Signup to host a Web3 call

A Brave Talk Premium account is required in order to host Web3 calls. Start your free trial now.

Link to FAQ: Learn more about Web3 calls with Brave Talk

johnhalbert pushed a commit that referenced this issue Apr 21, 2023
@johnhalbert
Copy link
Contributor

@mattmcalister @mrose17 do we want to display the text A Brave Talk Premium account is require... if they're a subscriber? Right now I have it so that doesn't display if they're subscribed to talk premium.

@mattmcalister
Copy link

good point. the original button was good if you are already logged in and have an active Premium subscription

@mrose17
Copy link
Member

mrose17 commented Apr 21, 2023

@mattmcalister - here is what we have now. how does this look?
Screen Shot 2023-04-21 at 17 45 52

@mrose17
Copy link
Member

mrose17 commented Apr 22, 2023

@srirambv - @johnhalbert pushed the fix yesterday, so reading for testing

@srirambv
Copy link
Collaborator Author

srirambv commented Apr 24, 2023

Changes look good. But shouldn't Select **a** unique NFT avatar be Select **an** unique NFT avatar?

image

Same here as well
image

@mrose17
Copy link
Member

mrose17 commented Apr 24, 2023

Oddly enough, in english "a unique" is considered correct. go figure...

@mrose17 mrose17 closed this as completed Apr 24, 2023
@mrose17
Copy link
Member

mrose17 commented Apr 24, 2023

well, after checking a grammar checker, apparently either works. so we'll change it, but ultimately our "wording czar" will make a final determination...

@mrose17 mrose17 added web3 and removed ready-for-qa labels Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants