fix "not a subscriber" diagnostic to reflect the actual error...

[srirambv]

Description

Show proper message when a user doesn't select any POAP/NFT when creating a Web3 Talk room

Steps

1. Create a premium subscription for Talk
2. Create a room
3. Do not select required NFT/POAP
4. Click on Start Web3 call
5. Shows Sorry, you are not a subscriber message instead of showing the actual reason

Actual Result

Wrong.Error.Message.mp4

Expected Result

Should show the actual reason for not creating the room

Additional Information

cc: @mrose17

[mrose17]

@srirambv - i think that this is a different bug, specifically that sometimes the browser seems to lose track of the fact that a user is a subscriber. i occasionally see the same error when I do select POAPs or NFTs.

i've changed the title to reflect this. if you disagree, please let me know so we can drill down a bit.

[mrose17]

update: it looks like Sri called it right, so there are a couple of things we can debug here!

[tackley]

The actual error is being hidden by that message. I can see from this interaction that the correct subscription cookies were set, the subscription server returned the error:

body: {"message":"Unable to verify web3 authorizations; error id: 9937e4fd-2dbd-4ff9-b68e-5f8ff86c41a3: No ADs given","code":400}

But chose to display the message "Sorry, you are not a subscriber", presumably as a catch-all error message.

[mrose17]

so, two things:

first, instead of "Sorry, you are not a subscriber" we should display body.message

second, do we know why the subscription service says it's unable to verify?

[johnhalbert]

@mrose17 I've pushed a fix for this. The messages returned from subscriptions are not well formatted for display on the client. So, instead of doing that I've updated the client to validate the request and print the appropriate message when a 400 is returned.

@srirambv this is ready for re-testing.

[mrose17]

hmmm... OK, let me see what kind of errors i see. cf., #850

[srirambv]

This is fixed now. I see the error Please choose one or more POAPs for participants or Please choose one or more NFT collections for participants.

823.mp4

@johnhalbert @mrose17 with selecting just moderator POAP/NFT the call room gets created. Should the message read to either select the required POAP/NFT or moderator POAP/NFT ?

[mrose17]

Cf., #850 in other words, a room is not required…