Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show proper message for not listed as participant #832

Closed
srirambv opened this issue Apr 21, 2023 · 5 comments
Closed

Show proper message for not listed as participant #832

srirambv opened this issue Apr 21, 2023 · 5 comments
Assignees
@johnhalbert
Labels
ui web3

Comments

@srirambv
Copy link
Collaborator

Description

Show proper message for not listed as participant

Steps

  1. Create a Web3 Talk call
  2. Try to join with an account that has the NFT but not set for participant
  3. Shows Request failed 401 instead of Not listed as a participant

Actual Result

image

Expected Result

Show Not listed as a participant instead of showing Request failed 401 error

Additional Information
@srirambv srirambv added the ui label Apr 21, 2023
@mrose17 mrose17 mentioned this issue Apr 21, 2023
Closed
@mrose17
Copy link
Member

mrose17 commented Apr 21, 2023

@mattmcalister - when toking gating fails, do we want to say "Access denied" or “the token gate is locked for you” or ...

@mattmcalister
Copy link

how about

Access failure: You must have an approved token to join this call.

@mrose17
Copy link
Member

mrose17 commented Apr 21, 2023

That works for me. @johnhalbert - let's go with this.

johnhalbert pushed a commit that referenced this issue Apr 24, 2023
Fixes #832
e59933a
@johnhalbert
Copy link
Contributor

@srirambv this is ready for re-test.

@srirambv
Copy link
Collaborator Author

This looks fixed
brave_lWjNnkSpzx

@mrose17 mrose17 added web3 and removed ready-for-qa labels Apr 25, 2023
@johnhalbert johnhalbert mentioned this issue Apr 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnhalbert johnhalbert

Labels
ui web3
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mattmcalister @mrose17 @johnhalbert @srirambv