Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

Using HTML select for walletPanel #434

Merged
merged 1 commit into from
Apr 8, 2019
Merged

Using HTML select for walletPanel #434

merged 1 commit into from
Apr 8, 2019

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Mar 21, 2019 •
edited
Loading

Changes

Using plain <select> for WalletPanel to avoid clipping issues. Should maintain the look and feel of the previous component.

Screen Shot 2019-03-20 at 5 14 53 PM

Test plan

https://brave-ui-gz4ablrx5.now.sh

Integration

  • Does this contain changes to src/components or src/

    • Will you publish to npm immediately after this PR, or wait until sometime in the future?
    • Incompatible API change to something existing (major version increase)
    • Adding new backwards-compatible functionality? (minor version increase)
    • Fixing a bug backwards-compatibly? (patch version increase)

  • Does this contain changes to src/features for brave-core?

    • Are there non backwards-compatible changes required for brave-core? Do not merge until brave-core PR is approvable. Link to brave-core PR:
    • Will you create brave-core PR to update to this commit after it is merged?
    • Wants uplift to brave-core feature branch?
      • When uplift-approved, merge to brave-core-0.VV.x feature branch
      • Create additional brave-core PRs for each feature branch to update commit

@ryanml ryanml self-assigned this Mar 21, 2019
@ryanml ryanml force-pushed the wallet-panel-select branch 3 times, most recently from 06d2711 to 8fc4814 Compare March 21, 2019 01:25
@ryanml ryanml mentioned this pull request Mar 21, 2019
Closed
18 tasks
@ryanml ryanml requested a review from NejcZdovc March 25, 2019 23:12
@ryanml ryanml mentioned this pull request Mar 25, 2019
Merged
18 tasks
@ryanml ryanml requested a review from NejcZdovc April 1, 2019 18:56
@ryanml ryanml merged commit 1b1ee01 into master Apr 8, 2019
@ryanml ryanml deleted the wallet-panel-select branch April 8, 2019 21:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@NejcZdovc NejcZdovc NejcZdovc approved these changes

@jasonrsadler jasonrsadler Awaiting requested review from jasonrsadler

Assignees

@ryanml ryanml

Labels
rewards
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ryanml @NejcZdovc