Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable whats-new for 1.52 in stable #633

Merged
merged 1 commit into from
May 30, 2023
Merged

Enable whats-new for 1.52 in stable #633

merged 1 commit into from
May 30, 2023

Conversation

simonhong
Copy link
Member

No description provided.

@simonhong simonhong self-assigned this May 25, 2023
@simonhong simonhong requested a review from a team as a code owner May 25, 2023 01:11
@stephendonner
Copy link

Verified PASSED using

Brave 1.52.115 Chromium: 114.0.5735.53 (Official Build) (x86_64)
Revision c499d7ea22c8b2dba278465a5df7b86a8efa4e64-refs/branch-heads/5735@{#970}
OS macOS Version 11.7.7 (Build 20G1345)

Steps:

  1. installed 1.52.115
  2. launched Brave using --variations-server-url=https://variations.bravesoftware.com/seed --update-feed-url=https://updates.bravesoftware.com/sparkle/Brave-Browser/test/appcast.xml
  3. checked for updates
  4. waited for the update to be downloaded and installed
  5. clicked on Relaunch
  6. upon relaunch, examined tabs

Confirmed the What's new in Brave? page opened in a new-tab window to the left of the previous tabs

example example example example
Screen Shot 2023-05-30 at 12 51 06 PM Screen Shot 2023-05-30 at 12 52 22 PM Screen Shot 2023-05-30 at 12 52 31 PM Screen Shot 2023-05-30 at 12 52 35 PM

kjozwiak
kjozwiak approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.52.x approved after deliberating with @brave/uplift-approvers.

@kjozwiak kjozwiak merged commit b87fc4e into production May 30, 2023
2 checks passed
@kjozwiak kjozwiak deleted the enable_whats_new_1.52 branch May 30, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@simonhong simonhong

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@simonhong @stephendonner @kjozwiak