Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

pinned tab disappears by reordering and unpinning #10037

Closed
luixxiul opened this issue Jul 18, 2017 · 3 comments · Fixed by #10531
Closed

pinned tab disappears by reordering and unpinning #10037

luixxiul opened this issue Jul 18, 2017 · 3 comments · Fixed by #10531
Labels
bug feature/pinned-tabs QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.20.x (Release C...

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Jul 18, 2017 •
edited
Loading

Test plan

#10531 (comment)

Describe the issue you encountered: pinned tab disappears by reordering and unpinning

  • Platform (Win7, 8, 10? macOS? Linux distro?): Debian

  • Brave Version (revision SHA): 0.17.17

  • Steps to reproduce:

    1. Open github.com in a tab
    2. Open twitter.com in a new tab
    3. Pin github
    4. Pin twitter
    5. Reorder the two pinned tabs
    6. Unpin github

  • Actual result: twitter, the other pinned tab, disappears

  • Expected result: it should not disapper

  • Any related issues:
@luixxiul luixxiul added this to the 0.21.x (Nightly Channel) milestone Jul 18, 2017
@luixxiul
Copy link
Contributor Author

the bug can be reproduced with any sites, including about pages

@LaurenWags
Copy link
Member

+1 from community https://community.brave.com/t/i-unpinned-one-tab-and-another-tab-disappeared/5268

@jamesray1
Copy link

I noticed a similar bug. I just tried to pin a tab and it disappears, when I have five other pinned tabs. I then unpinned a tab (the far right pinned tab) and two of the pinned tabs next to it disappeared. I was then able to pin a tab. I guess I'll have to not reorder pinned tabs until this bug is fixed.

petemill added a commit to petemill/browser-laptop that referenced this issue Aug 16, 2017
@petemill
Stop losing pinned tabs in a window when adding or removing another p…
fa9b09b 
…inned tab

Fix brave#3760, fix brave#9635, fix brave#10037, fix brave#10510, and possibly addresses brave#10117

The previous code resulted in tabs being marked as no longer required to be pinned, and closed prematurely. In many situations, when pinning a tab, all previously pinned tabs would be closed. Sometimes this appeared like a 'crash' when the window closed because all the tabs had been (undesirably) closed.
petemill added a commit to petemill/browser-laptop that referenced this issue Aug 16, 2017
@petemill
Stop losing pinned tabs in a window when adding or removing another p…
6248c7c 
…inned tab

Fix brave#3760, fix brave#9635, fix brave#10037, fix brave#10510, and possibly addresses brave#10117

The previous code resulted in tabs being marked as no longer required to be pinned, and closed prematurely. In many situations, when pinning a tab, all previously pinned tabs would be closed. Sometimes this appeared like a 'crash' when the window closed because all the tabs had been (undesirably) closed.
@petemill petemill mentioned this issue Aug 16, 2017
Merged
8 tasks
petemill added a commit to petemill/browser-laptop that referenced this issue Aug 26, 2017
@petemill
Stop losing pinned tabs in a window when adding or removing another p…
f912e34 
…inned tab

Fix brave#3760, fix brave#9635, fix brave#10037, fix brave#10510, and possibly addresses brave#10117

The previous code resulted in tabs being marked as no longer required to be pinned, and closed prematurely. In many situations, when pinning a tab, all previously pinned tabs would be closed. Sometimes this appeared like a 'crash' when the window closed because all the tabs had been (undesirably) closed.
petemill added a commit to petemill/browser-laptop that referenced this issue Aug 27, 2017
@petemill
Stop losing pinned tabs in a window when adding or removing another p…
a9443d5 
…inned tab

Fix brave#3760, fix brave#9635, fix brave#10037, fix brave#10510, and possibly addresses brave#10117

The previous code resulted in tabs being marked as no longer required to be pinned, and closed prematurely. In many situations, when pinning a tab, all previously pinned tabs would be closed. Sometimes this appeared like a 'crash' when the window closed because all the tabs had been (undesirably) closed.
petemill added a commit to petemill/browser-laptop that referenced this issue Aug 27, 2017
@petemill
Stop losing pinned tabs in a window when adding or removing another p…
f9a6772 
…inned tab

Fix brave#3760, fix brave#9635, fix brave#10037, fix brave#10510, and possibly addresses brave#10117

The previous code resulted in tabs being marked as no longer required to be pinned, and closed prematurely. This mostly occured after a pinned-tab reordering - afterwards, when pinning or unpinning a tab, all previously pinned tabs with a new order would be closed. Sometimes this appeared like a 'crash' when the window closed because all the tabs had been (undesirably) closed.
petemill added a commit to petemill/browser-laptop that referenced this issue Aug 28, 2017
@petemill
Stop losing pinned tabs in a window when adding or removing another p…
a8e12ab 
…inned tab

Fix brave#3760, fix brave#9635, fix brave#10037, fix brave#10510, and possibly addresses brave#10117

The previous code resulted in tabs being marked as no longer required to be pinned, and closed prematurely. This mostly occured after a pinned-tab reordering - afterwards, when pinning or unpinning a tab, all previously pinned tabs with a new order would be closed. Sometimes this appeared like a 'crash' when the window closed because all the tabs had been (undesirably) closed.
bsclifton pushed a commit to petemill/browser-laptop that referenced this issue Aug 29, 2017
@petemill @bsclifton
Stop losing pinned tabs in a window when adding or removing another p…
01008da 
…inned tab

Fix brave#3760, fix brave#9635, fix brave#10037, fix brave#10510, and possibly addresses brave#10117

The previous code resulted in tabs being marked as no longer required to be pinned, and closed prematurely. This mostly occured after a pinned-tab reordering - afterwards, when pinning or unpinning a tab, all previously pinned tabs with a new order would be closed. Sometimes this appeared like a 'crash' when the window closed because all the tabs had been (undesirably) closed.
@bbondy bbondy modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel) Oct 25, 2017
This was referenced Dec 20, 2017
Closed
Closed
@srirambv srirambv mentioned this issue Dec 27, 2017
Closed
35 tasks
@kjozwiak kjozwiak mentioned this issue Jan 31, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug feature/pinned-tabs QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.20.x (Release Channel)
6 participants
@bbondy @luixxiul @bsclifton @jamesray1 @srirambv @LaurenWags