Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Import cookie error #10043

Closed
darkdh opened this issue Jul 18, 2017 · 3 comments · Fixed by brave/muon#258
Closed

Import cookie error #10043

darkdh opened this issue Jul 18, 2017 · 3 comments · Fixed by brave/muon#258
Assignees
@darkdh
Labels
feature/importer QA/no-qa-needed release-notes/include security
Milestone
0.20.x (Release C...

Comments

@darkdh
Copy link
Member

darkdh commented Jul 18, 2017 •
edited by luixxiul
Loading

Error: Setting cookie failed
due to

  1. strict secure cookies (https://chromium.googlesource.com/chromium/src.git/+/a26e439d02baa9514b09c637bf5fa9f6790c4c3e)
  2. GetCookieDomainWithString check failed
@darkdh darkdh self-assigned this Jul 18, 2017
@darkdh darkdh added this to the 0.20.x (Developer Channel) milestone Jul 18, 2017
darkdh added a commit to brave/muon that referenced this issue Jul 18, 2017
@darkdh
Fix SetCookieWithDetailsAsync with failure callback
e82dd09 
fixes brave/browser-laptop#10043

Auditors: @bridiver, @diracdeltas, @bbondy
@darkdh darkdh mentioned this issue Jul 18, 2017
Merged
@luixxiul
Copy link
Contributor

@darkdh would you mind specifying the manual test plan? thanks!

@darkdh
Copy link
Member Author

darkdh commented Jul 31, 2017

Test plan

  1. Go to chrome's user folder and sqlite3 Cookies
  2. insert into cookies (creation_utc, host_key, name, value, path, expires_utc, secure, httponly, last_access_utc) values (13145664238592695, '.brave.com', 'brave_test', 'test', '/', 13177200238592692, 1, 1, 13145666083244049); <=== test for strict secure cookies
  3. insert into cookies (creation_utc, host_key, name, value, path, expires_utc, secure, httponly, last_access_utc) values (13145664238595566, 'braave.com', 'brave_test', 'test', '/', 13177200238595566, 0, 1, 13145666083245566); <=== test for GetCookieDomainWithString check failed
  4. exit sqlite3
  5. Launch Brave and import cookies from Chrome
  6. There will not be any console errors Error: Setting cookie failed

@darkdh
Copy link
Member Author

darkdh commented Sep 25, 2017

wrong scenario so and it is reverted here brave/muon@3a6ee2a
so no qa required

@kjozwiak kjozwiak mentioned this issue Jan 31, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
feature/importer QA/no-qa-needed release-notes/include security
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

Successfully merging a pull request may close this issue.

Fix SetCookieWithDetailsAsync with failure callback brave/muon
2 participants
@luixxiul @darkdh