Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Error while build-package #10060

Closed
luixxiul opened this issue Jul 19, 2017 · 1 comment · Fixed by #10068
Closed

Error while build-package #10060

luixxiul opened this issue Jul 19, 2017 · 1 comment · Fixed by #10068
Assignees
@darkdh
Labels
bug dev-setup QA/checked QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.18.x Release

Comments

@luixxiul
Copy link
Contributor

Describe the issue you encountered: error while build-package

  • Platform (Win7, 8, 10? macOS? Linux distro?): macOS

  • Brave Version (revision SHA): master

  • Steps to reproduce: git checkout master && git rebase upstream/master && rm -rf ~/.electron && rm -rf node_modules && npm i && CHANNEL=dev npm run build-package

  • Actual result:

    Packaging app for platform darwin x64 using electron v4.4.0
Wrote new app to /Users/Suguru/browser-laptop/Brave-darwin-x64
There were errors during the copy.
Error: ENOENT: no such file or directory, lstat '/Users/Suguru/browser-laptop/node_modules/spellchecker/vendor/hunspell_dictionaries'

  • Expected result: that error should not happen

  • Any related issues:
@luixxiul luixxiul added this to the 0.21.x (Nightly Channel) milestone Jul 19, 2017
@bsclifton bsclifton modified the milestones: 0.19.x (Beta Channel), 0.21.x (Nightly Channel) Jul 19, 2017
@bsclifton
Copy link
Member

Nice catch 😄 I believe this is happening because of #9880

@darkdh we may need to remove these two lines:
https://github.com/brave/browser-laptop/blob/master/tools/buildPackage.js#L127-L128

darkdh added a commit that referenced this issue Jul 19, 2017
@darkdh
Remove spellchecker packaging
e5c6622 
fixes #10060

Auditors: @bsclifton

Test Plan:
Run `CHANNEL=dev npm run build-package`
@darkdh darkdh mentioned this issue Jul 19, 2017
Merged
8 tasks
@bsclifton bsclifton modified the milestones: 0.18.x (Beta Channel), 0.19.x (Developer Channel) Jul 23, 2017
This was referenced Jul 24, 2017
Closed
Closed
@luixxiul luixxiul mentioned this issue Jul 26, 2017
Closed
44 tasks
This was referenced Jul 26, 2017
Closed
Closed
@alexwykoff alexwykoff mentioned this issue Jul 27, 2017
Closed
102 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
bug dev-setup QA/checked QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.18.x Release
Development

Successfully merging a pull request may close this issue.

Remove spellchecker packaging brave/browser-laptop
4 participants
@alexwykoff @luixxiul @bsclifton @darkdh