Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Blocking rules are not limited to private tabs #10829

Closed
NejcZdovc opened this issue Sep 6, 2017 · 3 comments
Closed

Blocking rules are not limited to private tabs #10829

NejcZdovc opened this issue Sep 6, 2017 · 3 comments
Assignees
@NejcZdovc
Labels
feature/adblock QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified regression release-notes/include security
Milestone
0.18.x Hotfix 2 (...

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Sep 6, 2017 •
edited by luixxiul
Loading

Test plan

#10836 (comment)

Describe the issue you encountered:

  12) Bravery Panel Adblock stats iframe tests detects blocked elements in iframe in private tab:
     Promise was rejected with the following reason: timeout
  Error

So what is happening here is that you set ad blocking rule in private tab and this rule is applied outside private tab as well.

Is this something that is intended? cc @diracdeltas
@NejcZdovc NejcZdovc added this to the 0.21.x (Nightly Channel) milestone Sep 6, 2017
@NejcZdovc NejcZdovc self-assigned this Sep 6, 2017
@diracdeltas
Copy link
Member

In general, site settings that are changed in a private tab should be written to temporarySiteSettings, not siteSettings. siteSettings and temporarySiteSettings are merged for private tabs, but only siteSettings applies to normal tabs.

so settings changed in private tabs should not affect regular tabs.

@NejcZdovc
Copy link
Contributor Author

ok, so this is a regression then. Will look into it

@NejcZdovc
Copy link
Contributor Author

NejcZdovc commented Sep 7, 2017 •
edited
Loading

this bug was introduced with #10289, problem is that when we cache bravery settings but we don't add private flag

@NejcZdovc NejcZdovc modified the milestones: 0.18.x Hotfix 2 (Release Channel), 0.21.x (Nightly Channel) Sep 7, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Sep 7, 2017
@NejcZdovc
Fixes cache problem with private tabs for siteSettings
91c7c15 
Resolves brave#10829

Auditors:

Test Plan:
@NejcZdovc NejcZdovc mentioned this issue Sep 7, 2017
Merged
8 tasks
diracdeltas added a commit that referenced this issue Sep 7, 2017
@diracdeltas
Merge pull request #10836 from NejcZdovc/hotfix/#10829-adblock
f69c5eb 
Fixes cache problem with private tabs for siteSettings
diracdeltas added a commit that referenced this issue Sep 7, 2017
@diracdeltas
Merge pull request #10836 from NejcZdovc/hotfix/#10829-adblock
6c0a6d7 
Fixes cache problem with private tabs for siteSettings
diracdeltas added a commit that referenced this issue Sep 7, 2017
@diracdeltas
Merge pull request #10836 from NejcZdovc/hotfix/#10829-adblock
45de5e9 
Fixes cache problem with private tabs for siteSettings
diracdeltas added a commit that referenced this issue Sep 7, 2017
@diracdeltas
Merge pull request #10836 from NejcZdovc/hotfix/#10829-adblock
9a3e292 
Fixes cache problem with private tabs for siteSettings
This was referenced Sep 14, 2017
Closed
Closed
Closed
Closed
@kjozwiak kjozwiak mentioned this issue Sep 15, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
feature/adblock QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified regression release-notes/include security
Projects
None yet
Milestone
0.18.x Hotfix 2 (Release Channel)
Development

No branches or pull requests
5 participants
@diracdeltas @kjozwiak @luixxiul @NejcZdovc @LaurenWags