Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

PDF Presentation Mode banner lists Chrome Extension #11020

Closed
LaurenWags opened this issue Sep 19, 2017 · 1 comment · Fixed by #11051
Closed

PDF Presentation Mode banner lists Chrome Extension #11020

LaurenWags opened this issue Sep 19, 2017 · 1 comment · Fixed by #11051
Assignees
@diracdeltas
Labels
bug feature/extensions plugin/pdfjs QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.20.x (Release C...

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Sep 19, 2017 •
edited by luixxiul
Loading

Test plan

#11051 (comment)

Description

When you have a PDF open and select the 'Switch to Presentation Mode' button, the notification banner displays 'Allow chrome-extension://jdbefljfgobbmcidnmpjamcbhnbphjnb to use fullscreen mode?'. This is confusing, I as expecting it to say something like 'PDF Viewer' instead of 'chrome-extension...'.

Steps to Reproduce

  1. Open a PDF/Navigate to a PDF.
  2. Click on the 'Switch to Presentation Mode' button.
  3. Banner displays.

Actual result:
screen shot 2017-09-19 at 3 47 13 pm

Expected result:
Banner should still display, but say something like 'PDF Viewer' instead of 'chrome-extension...'

Reproduces how often:
every time.

Brave Version

Brave | 0.18.36
rev | 7ab85e9
Muon | 4.3.22

Additional Information
@diracdeltas diracdeltas self-assigned this Sep 19, 2017
@diracdeltas diracdeltas added this to the 0.21.x (Nightly Channel) milestone Sep 19, 2017
@diracdeltas
Copy link
Member

should probably wait til #10896 is merged before fixing this since it will cause merge conflicts

diracdeltas added a commit that referenced this issue Sep 20, 2017
@diracdeltas
Use 'PDF Viewer' instead of 'chrome-extension://...' for notifications
f0841e5 
fix #11020

Test Plan:
1. open any PDF in Brave
2. click the fullscreen button
3. the notification should say 'Allow PDF Viewer to use fullscreen?'
@diracdeltas diracdeltas mentioned this issue Sep 20, 2017
Merged
8 tasks
@bbondy bbondy modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel) Oct 25, 2017
syuan100 pushed a commit to syuan100/browser-laptop that referenced this issue Nov 9, 2017
@diracdeltas @syuan100
Use 'PDF Viewer' instead of 'chrome-extension://...' for notifications
1234b54 
fix brave#11020

Test Plan:
1. open any PDF in Brave
2. click the fullscreen button
3. the notification should say 'Allow PDF Viewer to use fullscreen?'
@luixxiul luixxiul mentioned this issue Nov 14, 2017
Closed
This was referenced Dec 20, 2017
Closed
Closed
@kjozwiak kjozwiak mentioned this issue Jan 31, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@diracdeltas diracdeltas

Labels
bug feature/extensions plugin/pdfjs QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

Successfully merging a pull request may close this issue.

Use 'PDF Viewer' instead of 'chrome-extension://...' for notifications brave/browser-laptop
5 participants
@diracdeltas @bbondy @luixxiul @srirambv @LaurenWags