Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Oauth into Asana leaves a blank window open. #11050

Closed
alexwykoff opened this issue Sep 20, 2017 · 9 comments
Closed

Oauth into Asana leaves a blank window open. #11050

alexwykoff opened this issue Sep 20, 2017 · 9 comments
Labels
bug duplicate Issue has already been reported

Comments

@alexwykoff
Copy link
Contributor

Description

When logging into Asana, it allows for a user to use Oauth & their Google account.
After the handshake is complete, the new, smaller Oauth window is left open and is blank.

Steps to Reproduce

  1. Log into Google
  2. Log into Asana with Google

Actual result:
screen shot 2017-09-20 at 12 10 20 pm

Expected result:
Since the handshake is complete, the window should close.

Reproduces how often: [What percentage of the time does it reproduce?]
100%

Brave Version

about:brave info:

Brave: 0.19.9
rev: 2a9a56f
Muon: 4.4.19
libchromiumcontent: 61.0.3163.79
V8: 6.1.534.32
Node.js: 7.9.0
Update Channel: Beta
OS Platform: macOS
OS Release: 16.7.0
OS Architecture: x64

Reproducible on current live release:
Unsure, needs investigation.

Additional Information

@jamesray1
Copy link

jamesray1 commented Sep 20, 2017

Yes I get the same result (a blank small window after clicking to sign in with Google) for OAuth with Google on about.me.
Twitter OAuth works, but Facebook and Google doesn't.

Brave: 0.18.29
rev: 85f059d
Muon: 4.3.16
libchromiumcontent: 60.0.3112.113
V8: 6.0.286.56
Node.js: 7.9.0
Update Channel: dev
OS Platform: Linux
OS Release: 4.10.0-33-generic
OS Architecture: x64

@luixxiul luixxiul added the bug label Sep 21, 2017
@luixxiul
Copy link
Contributor

me too. I noticed that when I logged in with Facebook.

@eduardonunesp
Copy link

Hummm interesting maybe something related to the window.close(), after the handshake completed some window.close() should be called. Maybe some reference to the window.opener isn't passed to the new window.

@bsclifton
Copy link
Member

I believe this is related to window.close not working as expected

cc: @jonathansampson @kevinlawler

@jonathansampson
Copy link
Collaborator

jonathansampson commented Oct 27, 2017

I was able to repro fairly easily.

I don't think this is an issue with window.close necessarily. Note that the tab is closed, but the popup window doesn't know that all tabs are closed. As such, the window stays open.

@cezaraugusto cezaraugusto added this to the Triage Backlog milestone Nov 8, 2017
@jrmoreau
Copy link

Any update on this? Experiencing the same. Also experiencing after I confirm a tx on MEW with Trezor

@bsclifton
Copy link
Member

Closing as a duplicate of #13370

@bsclifton bsclifton added the duplicate Issue has already been reported label Jul 27, 2018
@jamesray1
Copy link

jamesray1 commented Jul 30, 2018

Technically, this happened first, so #13370 would be a duplicate.

@bsclifton
Copy link
Member

bsclifton commented Jul 30, 2018

The original issue was #9610 which was closed in favor of #13370 since it had more detail 😄 More detail in an issue is more important than a lower issue number

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug duplicate Issue has already been reported
Projects
None yet
Development

No branches or pull requests

8 participants