Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

PDF.js viewer error #11059

Closed
luixxiul opened this issue Sep 21, 2017 · 9 comments
Closed

PDF.js viewer error #11059

luixxiul opened this issue Sep 21, 2017 · 9 comments
Labels
bug duplicate Issue has already been reported plugin/pdfjs priority/P3 Major loss of function.

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Sep 21, 2017

Description

https://community.brave.com/t/pdf-js-viewer-error/7825?u=suguru

I’ve noticed a glitch when trying to open download links via email (Airmail 3).

Scenario…
I’ve sent dropbox links to a client to download some PDF files.
Sent message links open up a brave window and fail to download.
I get an ‘Invalid or corrupt PDF file’ message when the PDF.js viewer file loads.

Only happens in Brave (0.18.36), links work fine in Safari (10.1.2). Macbook Pro running OS 10.10.5.

I don’t think the client (Windows) had an issue either but this is a recurring issue with Brave. Interrupts my workflow a bit. Hoping somebody can shed some light on it.

Steps to Reproduce

  1. Send dropbox links to a client to download some PDF files.
  2. Send message links open up a brave window and fail to download

Actual result:

The user claims he got an ‘Invalid or corrupt PDF file’ message when the PDF.js viewer file loaded.

Expected result:

It should load the PDF file.

Reproduces how often: [What percentage of the time does it reproduce?]

Brave Version

about:brave info:

0.18.36

Reproducible on current live release:

Additional Information

this looks related: #8748

@rhubarbwibble
Copy link

rhubarbwibble commented Sep 21, 2017

Reproduces how often: 100% with every dropbox link to a PDF. All other file formats are fine.

@tbates
Copy link

tbates commented Sep 23, 2017

Here's another example: opens fine under safari on os x high sierra golden candidate, fails under brace on same OS

https://www.dropbox.com/s/4nfqksi0b1leh4o/Meet%20the%20Faculty%202017-18%20final.pdf?dl=0

@bsclifton
Copy link
Member

cc: @diracdeltas

@dcfranca
Copy link

It seems to happen when the url is not pointing to a pdf itself, but working as a router or container for the file itself.
The same issue happens when trying to open a pdf link on github, i.e: https://github.com/datproject/docs/blob/master/papers/dat-paper.pdf

@bsclifton bsclifton added the priority/P3 Major loss of function. label Sep 28, 2017
@hp4k1h5
Copy link

hp4k1h5 commented Oct 16, 2017

in Brave | 0.19.48 macosx sierra
i think danielfranca is onto the issue
just tried with
https://t.co/35e64NwVjV
which is for
https://lirias.kuleuven.be/bitstream/123456789/547640/1/usenix2016-wifi.pdf
the first opens to blank page, the second displays normally

@jaanli
Copy link

jaanli commented Oct 30, 2017

Another example that breaks on brave but works on chrome: https://openreview.net/pdf?id=B184E5qee

@bsclifton bsclifton added this to the Backlog (Prioritized) milestone Nov 22, 2017
@jabowery
Copy link

A direct pdf URL that fails on Brave and works on Chrome:

http://www.springerlink.com/index/g7461622624812j6.pdf

This happens a lot.

@jabowery
Copy link

Please correct the original post's Actual Result where it says "corrupt". It should say "corrupted". This is not a nit. People searching for the error message need this correctly quoted in the bug report.

humphd added a commit to humphd/browser-laptop that referenced this issue Mar 23, 2018
@NejcZdovc NejcZdovc modified the milestones: Backlog (Prioritized), Completed work Mar 27, 2018
@alexwykoff alexwykoff modified the milestones: Completed work, 0.25.x Apr 10, 2018
humphd added a commit to humphd/browser-laptop that referenced this issue Apr 30, 2018
humphd added a commit to humphd/browser-laptop that referenced this issue Jul 13, 2018
diracdeltas added a commit that referenced this issue Jul 18, 2018
 Fix #10554, #11059: remove check for .pdf in URL extensions, prefer response headers
diracdeltas added a commit that referenced this issue Jul 18, 2018
 Fix #10554, #11059: remove check for .pdf in URL extensions, prefer response headers
@bsclifton
Copy link
Member

Closing as a dupe of #10554

@bsclifton bsclifton added the duplicate Issue has already been reported label Jul 23, 2018
@bsclifton bsclifton removed this from the 0.24.x (Developer Channel) milestone Jul 23, 2018
bsclifton pushed a commit that referenced this issue Jul 23, 2018
 Fix #10554, #11059: remove check for .pdf in URL extensions, prefer response headers
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug duplicate Issue has already been reported plugin/pdfjs priority/P3 Major loss of function.
Projects
None yet
Development

No branches or pull requests

10 participants