Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

unable to highlight sync words for copying #11641

Closed
LaurenWags opened this issue Oct 23, 2017 · 4 comments
Closed

unable to highlight sync words for copying #11641

LaurenWags opened this issue Oct 23, 2017 · 4 comments

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Oct 23, 2017

Test plan

#11670 (comment)


Description

On the 'Sync a new device' popup we are no longer able to highlight the sync words so we can copy/paste them. This last worked with 0.19.54 and stopped working in 0.19.57.

Steps to Reproduce

  1. Enable sync.
  2. Open 'Sync a new device' popup.
  3. Select 'show secret code words'.

Actual result:
Unable to highlight the sync code words:
syncwords

Expected result:
Should be able to highlight the sync code words as before.
syncwords01954

Reproduces how often: [What percentage of the time does it reproduce?] 100%

Brave Version

about:brave info:
Brave | 0.19.62
rev | fe3f350
Muon | 4.5.7

Reproducible on current live release:
no, this is not broken on 0.19.53

Additional Information

Possibly introduced with cr62, which was also introduced in 0.19.57.
cc @srirambv

@luixxiul
Copy link
Contributor

https://github.com/brave/browser-laptop/blame/1bb8ff174e8781db05d48c0c86de41e19d04e048/app/renderer/components/preferences/syncTab.js#L608

user-select: initial seems to have changed how it behaves since cr62 (since the code has been there for 6 month). there might be a similar case inside the code.

changing it to user-select: text should work.

@luixxiul
Copy link
Contributor

Since the fix is ready (PR has been submitted), it is ok to escalate this to hotfix 2.

@bsclifton
Copy link
Member

This will be an important one to test on Windows (which is a little more picky about these attributes)

@kjozwiak
Copy link
Member

kjozwiak commented Nov 1, 2017

This issue also affected the backup keys under about:preferences#payments, checked on all the platforms to ensure that it has been resolved with this fix as well:

  • Ubuntu 17.04 x64 - Copied both sync & wallet keys using the cursor without any issues
  • macOS x64 - Copied wallet keys using the cursor without any issues (sync already checked)
  • Win 10 x64 - Copied wallet keys using the cursor without any issues (sync already checked)

syuan100 pushed a commit to syuan100/browser-laptop that referenced this issue Nov 9, 2017
Due to the Chromium 62 update

Fixes brave#11641

Auditors:

Test Plan:
1. Open about:preferences#sync
2. Enable Sync
3. Open 'Sync a new device'
4. Select `Show secret code words`
5. Make sure the words can be selected
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.