USD conversion for wallet balance always shows 1.00

[evq]

Description

Essentially despite rates being successfully retrieved, the calculated conversion value is never updated and shows 1.00:

See #11931 (comment) after it was closed for original discussion on this issue.

LEDGER_VERBOSE=1 logs:

[ response for GET https://balance.mercury.basicattentiontoken.org/v2/wallet/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx/balance ]                                                                                                        [321/10438]
>>> HTTP/1.1 200
>>> accept-ranges: bytes
>>> cache-control: private
>>> connection: keep-alive
>>> content-length: 207
>>> content-type: application/json; charset=utf-8
>>> date: Wed, 15 Nov 2017 23:24:47 GMT
>>> server: Cowboy
>>> vary: accept-encoding
>>> via: 1.1 vegur
>>> x-rate-limit-limit: 60
>>> x-rate-limit-remaining: 57
>>> x-rate-limit-reset: 1510788301
>>>
>>> {"altcurrency":"BAT","probi":"7.309622404968674704085e+21","balance":"7309.6224","unconfirmed":"0.0000","rates":{"BTC":"0.00001966","ETH":0.00042591989579941384,"USD":0.1433458965,"EUR":0.12100429176330299}}
[ response for GET https://mercury-proxy.privateinternetaccess.com/v3/publisher/timestamp ]
>>> HTTP/1.1 200
>>> accept-ranges: bytes
>>> cache-control: private
>>> connection: keep-alive
>>> content-length: 35
>>> content-type: application/json; charset=utf-8
>>> date: Wed, 15 Nov 2017 23:24:47 GMT
>>> server: Cowboy
>>> strict-transport-security: max-age=31536000
>>> vary: accept-encoding
>>> via: 1.1 vegur
>>> x-rate-limit-limit: 9007199254740991
>>> x-rate-limit-remaining: 9007199254740990
>>> x-rate-limit-reset: 1510788288
>>>
>>> {"timestamp":"6488746555397373953"}
[ response for GET https://balance.mercury.basicattentiontoken.org/v2/wallet/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx/balance ]
>>> HTTP/1.1 200
>>> accept-ranges: bytes
>>> cache-control: private
>>> connection: keep-alive
>>> content-length: 207
>>> content-type: application/json; charset=utf-8
>>> date: Wed, 15 Nov 2017 23:24:47 GMT
>>> server: Cowboy
>>> vary: accept-encoding
>>> via: 1.1 vegur
>>> x-rate-limit-limit: 60
>>> x-rate-limit-remaining: 56
>>> x-rate-limit-reset: 1510788300
>>>
>>> {"altcurrency":"BAT","probi":"7.309622404968674704085e+21","balance":"7309.6224","unconfirmed":"0.0000","rates":{"BTC":"0.00001966","ETH":0.00042591989579941384,"USD":0.1433458965,"EUR":0.12100429176330299}}

getBalance refreshes ledger info: 0

Steps to Reproduce

Actual result:

Expected result:

Reproduces how often:

Brave Version

Brave: 0.19.93
rev: 25085d0
Muon: 4.5.16
libchromiumcontent: 62.0.3202.94
V8: 6.2.414.42
Node.js: 7.9.0
Update Channel: Release
OS Platform: macOS
OS Release: 16.7.0
OS Architecture: x64

Reproducible on current live release:

yes (with @darkdh profile)

Additional Information

[kjozwiak]

@darkdh can you install 0.19.100 and see if the issue you were having with your wallet conversion as been fixed?

[darkdh]

0.19.100 works for me !!!

[kjozwiak]

Thanks @darkdh! I'm going to mark this as tested as it fixed the issue @darkdh was having as well. I talked to @evq last night and this would be difficult to test for QA unless we create a wallet with a huge balance... Either way, it looks like it's working.