Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

passwords not saved #12063

Closed
LaurenWags opened this issue Nov 22, 2017 · 3 comments
Closed

passwords not saved #12063

LaurenWags opened this issue Nov 22, 2017 · 3 comments

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Nov 22, 2017

Description

Brave is not saving passwords.

Test plan / Steps to Reproduce

  1. Clean profile for 0.20.7 (packaged beta build)
  2. Navigate to site (I used https://trac.torproject.org/projects/tor/login) and enter login credentials.
  3. Select 'Allow' in notification.
  4. Navigate to about:passwords

Actual result:
Username/Password is not saved.
pwdoesntsave

Expected result:
Username/Password should be saved.

Reproduces how often:
Easily

Brave Version

about:brave info:
Brave | 0.20.7
V8 | 6.2.414.42
rev | a2ba3e8
Muon | 4.5.16

Reproducible on current live release:
Not for me, but there is this issue which was reported for current release: #12038

Additional Information

I can repro on MacOS consistently, @srirambv does not see this on Windows.

@kjozwiak
Copy link
Member

@LaurenWags is it possible that you clicked on "Deny" when you were prompted for "Chromium Safe Storage" access? When I select "Deny", passwords aren't being added into about:passwords. However, when I allow access, the passwords are being saved under about:passwords without any issues...

Example of the "Chromium Safe Storage" permission prompt:

screen shot 2017-11-22 at 1 15 06 pm

@alexwykoff alexwykoff added the priority/P1 Blocks development or testing. Product cannot run. Must be fixed immediately, shipped next release. label Nov 29, 2017
@alexwykoff
Copy link
Contributor

@LaurenWags please retest when you have a moment, thanks!

@LaurenWags
Copy link
Member Author

couldn't repro, closing issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants