Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

revert muted media should be able to autoplay #12152

Closed
darkdh opened this issue Dec 1, 2017 · 7 comments · Fixed by brave/muon#394
Closed

revert muted media should be able to autoplay #12152

darkdh opened this issue Dec 1, 2017 · 7 comments · Fixed by brave/muon#394
Assignees
@darkdh
Labels
feature/autoplay QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.19.x Hotfix 12 ...

Comments

@darkdh
Copy link
Member

darkdh commented Dec 1, 2017 •
edited by kjozwiak

Test Case 1

  1. visit about:preferences#security and ensure autoplay is set as Always Ask
  2. visit https://www.twitter.com and click on a tweet that has a video attached
  3. ensure that a autoplay notification is displayed and the video doesn't automatically play

Test Case 2

  1. visit about:preferences#security and ensure autoplay is set as Always Deny
  2. visit https://www.twitter.com and click on a tweet that has a video attached
  3. ensure that a autoplay notification isn't being displayed and the video doesn't automatically play

Test Case 3

  1. visit about:preferences#security and ensure autoplay is set as Always Allow
  2. visit https://www.twitter.com and click on a tweet that has a video attached
  3. ensure that the video is automatically being played
@darkdh darkdh self-assigned this Dec 1, 2017
darkdh added a commit to brave/muon that referenced this issue Dec 1, 2017
@darkdh
1. Audio element should also repect auotplay setting
7c1bbd3 
fix brave/browser-laptop#11988
fix brave/browser-laptop#11527

2. Don't check user initiated video
fix brave/browser-laptop#12149

3. Default allow muted media
fix brave/browser-laptop#12152

Auditors: @bridiver, @bbondy, @bsclifton
darkdh added a commit to brave/muon that referenced this issue Dec 1, 2017
@darkdh
1. Audio element should also repect auotplay setting
a3fff6b 
fix brave/browser-laptop#11988
fix brave/browser-laptop#11527

2. Don't check user initiated video
fix brave/browser-laptop#12149

3. Default allow muted media
fix brave/browser-laptop#12152

4. Default allow for local files
fix brave/browser-laptop#8929

Auditors: @bridiver, @bbondy, @bsclifton
@darkdh darkdh mentioned this issue Dec 1, 2017
Merged
darkdh added a commit to brave/muon that referenced this issue Dec 18, 2017
@darkdh
1. Audio element should also repect auotplay setting
4850c4f 
fix brave/browser-laptop#11988
fix brave/browser-laptop#11527

2. Don't check user initiated video
fix brave/browser-laptop#12149

3. Default allow muted media
fix brave/browser-laptop#12152

4. Default allow for local files
fix brave/browser-laptop#8929

Auditors: @bridiver, @bbondy, @bsclifton
darkdh added a commit to brave/muon that referenced this issue Dec 21, 2017
@darkdh
1. Audio element should also repect auotplay setting
8a54a8f 
fix brave/browser-laptop#11988
fix brave/browser-laptop#11527

2. Don't check user initiated video
fix brave/browser-laptop#12149

3. Default allow muted media
fix brave/browser-laptop#12152

4. Default allow for local files
fix brave/browser-laptop#8929

Auditors: @bridiver, @bbondy, @bsclifton
darkdh added a commit to brave/muon that referenced this issue Dec 27, 2017
@darkdh
1. Audio element should also repect auotplay setting
614c802 
fix brave/browser-laptop#11988
fix brave/browser-laptop#11527

2. Don't check user initiated video
fix brave/browser-laptop#12149

3. Default allow muted media
fix brave/browser-laptop#12152

4. Default allow for local files
fix brave/browser-laptop#8929

Auditors: @bridiver, @bbondy, @bsclifton
darkdh added a commit to brave/muon that referenced this issue Dec 29, 2017
@darkdh
1. Audio element should also repect auotplay setting
3335024 
fix brave/browser-laptop#11988
fix brave/browser-laptop#11527

2. Don't check user initiated video
fix brave/browser-laptop#12149

3. Default allow muted media
fix brave/browser-laptop#12152

4. Default allow for local files
fix brave/browser-laptop#8929

Auditors: @bridiver, @bbondy, @bsclifton
darkdh added a commit to brave/muon that referenced this issue Dec 29, 2017
@darkdh
1. Audio element should also repect auotplay setting
a599bca 
fix brave/browser-laptop#11988
fix brave/browser-laptop#11527

2. Don't check user initiated video
fix brave/browser-laptop#12149

3. Default allow muted media
fix brave/browser-laptop#12152

4. Default allow for local files
fix brave/browser-laptop#8929

Auditors: @bridiver, @bbondy, @bsclifton
darkdh added a commit to brave/muon that referenced this issue Dec 29, 2017
@darkdh
1. Audio element should also repect auotplay setting
21d55fd 
fix brave/browser-laptop#11988
fix brave/browser-laptop#11527

2. Don't check user initiated video
fix brave/browser-laptop#12149

3. Default allow muted media
fix brave/browser-laptop#12152

4. Default allow for local files
fix brave/browser-laptop#8929

Auditors: @bridiver, @bbondy, @bsclifton
darkdh added a commit to brave/muon that referenced this issue Dec 29, 2017
@darkdh
1. Audio element should also repect auotplay setting
6e029ce 
fix brave/browser-laptop#11988
fix brave/browser-laptop#11527

2. Don't check user initiated video
fix brave/browser-laptop#12149

3. Default allow muted media
fix brave/browser-laptop#12152

4. Default allow for local files
fix brave/browser-laptop#8929

Auditors: @bridiver, @bbondy, @bsclifton
@darkdh darkdh added this to the 0.20.x (Beta Channel) milestone Dec 29, 2017
@bsclifton bsclifton modified the milestones: 0.20.x (Beta Channel), 0.19.x Hotfix 11 (Release Channel) Jan 4, 2018
This was referenced Jan 4, 2018
Closed
Closed
Closed
@LaurenWags
Copy link
Member

If you have your Autoplay Media set to 'Always Ask', and you visit https://giphy.com/gifs/volkswagen-beetle-vw-3o6ozgHi0Fv82zA12M, you are asked if you want to allow the video to play, but it is already playing:
12152-a

@LaurenWags LaurenWags reopened this Jan 4, 2018
@darkdh
Copy link
Member Author

darkdh commented Jan 4, 2018

this requires uplift some 0.20.x PRs 0.19.x
https://github.com/brave/browser-laptop/pulls?q=is%3Apr+milestone%3A%220.20.x+%28Beta+Channel%29%22+is%3Aclosed+label%3Afeature%2Fautoplay

@darkdh
Copy link
Member Author

darkdh commented Jan 4, 2018

fixed by d81a458

@darkdh darkdh closed this as completed Jan 4, 2018
@LaurenWags LaurenWags mentioned this issue Jan 5, 2018
Closed
@darkdh
Copy link
Member Author

darkdh commented Jan 9, 2018 •
edited

this will be reverted in 0.21.x

@kjozwiak kjozwiak mentioned this issue Jan 9, 2018
Closed
@srirambv srirambv mentioned this issue Jan 11, 2018
Closed
@kjozwiak
Copy link
Member

@darkdh @bsclifton and myself had a quick chat. Because we're getting some user concerns on social media, this is going to be reverted in 0.19.x hotfix12.

Clearing all the QA Checked flags so this can be retested once the change has been reverted from muon and a new 0.19.x build becomes available sometime today.

@kjozwiak kjozwiak modified the milestones: 0.19.x Hotfix 11 (Release Channel), 0.19.x Hotfix 12 Jan 11, 2018
@bsclifton bsclifton mentioned this issue Jan 11, 2018
Closed
This was referenced Jan 12, 2018
Closed
Closed
Closed
@srirambv
Copy link
Collaborator

Test plan works fine on Windows

For test plan 1
Prompted notification when opened https://twitter.com/cricbuzz/status/951687708438552581 and https://www.cnet.com/news/oneplus-ceo-were-going-to-start-talking-to-us-carriers/
12152-ask

For test plan 2
Video notification didn't prompt when opened https://twitter.com/cricbuzz/status/951687708438552581 and https://www.cnet.com/news/oneplus-ceo-were-going-to-start-talking-to-us-carriers/
12152-deny

For test plan 3
Media autoplayed when opened https://twitter.com/cricbuzz/status/951687708438552581 and https://www.cnet.com/news/oneplus-ceo-were-going-to-start-talking-to-us-carriers/
12152-allow

@srirambv
Copy link
Collaborator

Works on Linux as well. Followed the same steps as above^

@kjozwiak kjozwiak changed the title Muted Media should be able to autoplay revert muted media should be able to autoplay Jan 12, 2018
@kjozwiak kjozwiak mentioned this issue Jan 12, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
feature/autoplay QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.19.x Hotfix 12 (Release Channel)
Development

Successfully merging a pull request may close this issue.

Autoplay issues fix brave/muon
5 participants
@kjozwiak @bsclifton @darkdh @srirambv @LaurenWags