Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Incorrect decimal values shown for BAT-USD after reconcile #12666

Closed
srirambv opened this issue Jan 16, 2018 · 11 comments
Closed

Incorrect decimal values shown for BAT-USD after reconcile #12666

srirambv opened this issue Jan 16, 2018 · 11 comments
Assignees
@NejcZdovc
Labels
0.21.x issue first seen in 0.21.x bug feature/rewards initiative/bat-payments QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.21.x (Release C...

Comments

@srirambv
Copy link
Collaborator

srirambv commented Jan 16, 2018 •
edited by bsclifton
Loading

Description

Incorrect decimal values shown for BAT-USD after reconcile

Test plan / Steps to Reproduce

  1. Fund wallet with decimal values such as 7.51 BAT
  2. Change reconcilestamp to trigger payment process
  3. Once reconcile is complete, shows incorrect decimal values for BAT-USD

Actual result:
image

Expected result:
Should show correct BAT-USD values even for decimal values

Reproduces how often:
100%

Brave Version

about:brave info:

Brave 0.19.136
rev 1659471
Muon 4.7.1
libchromiumcontent 64.0.3282.85
V8 6.4.388.20
Node.js 7.9.0
Update Channel Release
OS Platform Microsoft Windows
OS Release 10.0.16299
OS Architecture x64

Reproducible on current live release:
Yes

Additional Information

Found the scenario on staging wallet.
browser profile
cc: @mrose17 @evq @bsclifton
@srirambv srirambv added this to the Triage Backlog milestone Jan 16, 2018
@NejcZdovc
Copy link
Contributor

@bradleyrichter what should we display here? USD value is 0.0066051665 and we only show two places and because of rounding we are currently displaying 0.01 USD which is of course wrong

@NejcZdovc NejcZdovc added the needs-info Another team member needs information from the PR/issue opener. label Jan 16, 2018
@NejcZdovc
Copy link
Contributor

This line is problematic https://github.com/brave/browser-laptop/blob/master/app/browser/api/ledger.js#L1614

@mrose17
Copy link
Member

mrose17 commented Jan 16, 2018

how about <.01USD ?

@bradleyrichter
Copy link
Contributor

bradleyrichter commented Jan 18, 2018 via email

@NejcZdovc NejcZdovc modified the milestones: Triage Backlog, 0.20.x Hotfix 1 Jan 19, 2018
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jan 19, 2018
@NejcZdovc
Adds handler for amounts lower then 0.01 USD
6ab6715 
Resolves brave#12666

Auditors:

Test Plan:
@NejcZdovc NejcZdovc mentioned this issue Jan 19, 2018
Merged
10 tasks
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jan 19, 2018
@NejcZdovc
Adds handler for amounts lower then 0.01 USD
ddcedf9 
Resolves brave#12666

Auditors:

Test Plan:
@alexwykoff alexwykoff modified the milestones: 0.20.x Hotfix 3 (Ledger improvments), 0.21.x (Beta Channel) Feb 6, 2018
bsclifton pushed a commit to NejcZdovc/browser-laptop that referenced this issue Feb 12, 2018
@NejcZdovc @bsclifton
Adds handler for amounts lower then 0.01 USD
6052639 
Resolves brave#12666

Auditors:

Test Plan:
bsclifton added a commit that referenced this issue Feb 12, 2018
@bsclifton
Merge pull request #12726 from NejcZdovc/hotfix/#12666-small
a6cadeb 
Adds handler for amounts lower then 0.01 USD
bsclifton added a commit that referenced this issue Feb 12, 2018
@bsclifton
Merge pull request #12726 from NejcZdovc/hotfix/#12666-small
e0d5c3a 
Adds handler for amounts lower then 0.01 USD
bsclifton added a commit that referenced this issue Feb 12, 2018
@bsclifton
Merge pull request #12726 from NejcZdovc/hotfix/#12666-small
d088983 
Adds handler for amounts lower then 0.01 USD
@srirambv srirambv mentioned this issue Feb 21, 2018
Closed
@LaurenWags
Copy link
Member

Showing <.01 USD on MacOS:
screen shot 2018-02-23 at 2 50 46 pm

@bradleyrichter
Copy link
Contributor

@NejcZdovc I think it would look better to add a leading 0.

So, 0.01 BAT (< 0.01 USD)

@LaurenWags
Copy link
Member

And a space between the < and the leading zero as in your example @bradleyrichter ? Meaning:
0.01 BAT (< 0.01 USD) vs 0.01 BAT (<0.01 USD)

@NejcZdovc NejcZdovc modified the milestones: 0.21.x (Beta Channel), 0.21.x (Twitch) Feb 24, 2018
NejcZdovc pushed a commit that referenced this issue Feb 24, 2018
@bsclifton @NejcZdovc
Merge pull request #12726 from NejcZdovc/hotfix/#12666-small
b06ee8d 
Adds handler for amounts lower then 0.01 USD
@NejcZdovc NejcZdovc reopened this Feb 24, 2018
@NejcZdovc
Copy link
Contributor

Reopening, so that we can adjust this value

NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Feb 24, 2018
@NejcZdovc
Fixes low amounts display
3c04166 
Resolves brave#12666

Auditors:

Test Plan:
@NejcZdovc NejcZdovc mentioned this issue Feb 24, 2018
Merged
10 tasks
bsclifton pushed a commit to NejcZdovc/browser-laptop that referenced this issue Feb 25, 2018
@NejcZdovc @bsclifton
Fixes low amounts display
97a846d 
Resolves brave#12666

Auditors:

Test Plan:
bsclifton added a commit that referenced this issue Feb 25, 2018
@bsclifton
Merge pull request #13292 from NejcZdovc/hotfix/#12666-fines
7eaae38 
Fixes low amounts display
bsclifton added a commit that referenced this issue Feb 25, 2018
@bsclifton
Merge pull request #13292 from NejcZdovc/hotfix/#12666-fines
be745fc 
Fixes low amounts display
bsclifton added a commit that referenced this issue Feb 25, 2018
@bsclifton
Merge pull request #13292 from NejcZdovc/hotfix/#12666-fines
5652166 
Fixes low amounts display
ryanml pushed a commit to ryanml/browser-laptop that referenced this issue Feb 27, 2018
@NejcZdovc @ryanml
Fixes low amounts display
4c00fd2 
Resolves brave#12666

Auditors:

Test Plan:
@srirambv srirambv added the 0.21.x issue first seen in 0.21.x label Feb 27, 2018
@srirambv
Copy link
Collaborator Author

Looks good on Windows
image

@LaurenWags
Copy link
Member

MacOS:
screen shot 2018-02-27 at 11 07 17 am

@kjozwiak kjozwiak mentioned this issue Feb 27, 2018
Closed
@kjozwiak
Copy link
Member

Looks good under Ubuntu 17.10 x64 👍 Used 0.21.16 a7bed47 without any issues.

screen shot 2018-02-27 at 9 26 31 pm

@kjozwiak kjozwiak mentioned this issue Mar 1, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
0.21.x issue first seen in 0.21.x bug feature/rewards initiative/bat-payments QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.21.x (Release Channel)
Development

No branches or pull requests
8 participants
@mrose17 @alexwykoff @kjozwiak @bsclifton @NejcZdovc @bradleyrichter @srirambv @LaurenWags