Bake about:welcome into Brave

[tildelowengrimm]

Per @liunkae's comments on #12632, about:welcome makes a bunch of network requests without user interaction, a move that surprises users. We should avoid requesting remote resources unless a user initiates the interaction.

[diracdeltas]

this is coming from https://brave.com/welcome/ - may be a better issue for the brave-website repo?

[tildelowengrimm]

As a user, it's surprising that an about: page is just a remote resource. IMO, we should bake this whole page into the Browser.

[bsclifton]

@flamsmark pulling in @bradleyrichter and @cezaraugusto

I believe that was the long term goal. This was a great first rev solution since updating the content for users is relatively easy. Now that it's live, I don't think we've updated it

[bradleyrichter]

Interesting of note, Opera and Edge both use a remote resource as well.

For us, the reason was to allow for faster iteration and building without dev resources.

Our next version of the welcome experience will need to go through a refinement stage as we get more feedback. After it solidifies, we could move it to browser-internal if resources are available.

[tildelowengrimm]

Beyond the privacy and perf benefits, a local page can be given greater capabilities. We could put things like a safe browsing or analytics switch right in the page, rather than bouncing the user out to a separate settings page. That could make it so much easier for folks to turn on important features.

[bridiver]

any objections to closing this in favor of brave/brave-browser#276 ?

[bsclifton]

@bridiver nope- let's close it up