Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change remote welcome page into a local webui welcome page #276

Closed
bbondy opened this issue Jun 5, 2018 · 2 comments · Fixed by brave/brave-core#256
Closed

Change remote welcome page into a local webui welcome page #276

bbondy opened this issue Jun 5, 2018 · 2 comments · Fixed by brave/brave-core#256
Assignees
@cezaraugusto
Labels
about-pages/welcome feature/brave-pages QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Milestone
0.55.x - Release ...

Comments

@bbondy
Copy link
Member

bbondy commented Jun 5, 2018

No description provided.

@bbondy bbondy mentioned this issue Jun 5, 2018
Merged
9 tasks
@bridiver bridiver mentioned this issue Jun 5, 2018
Closed
@cezaraugusto cezaraugusto self-assigned this Jun 5, 2018
@bbondy bbondy added this to Cezar Augusto in 0.55.x - Release Jun 6, 2018
cezaraugusto added a commit to brave/brave-core that referenced this issue Jun 22, 2018
@cezaraugusto
add about:welcome and webui handler
6b221b3 
-
adds basic UI handler for welcome page without usable UI
while design finish the new spec for the page
-
address brave/brave-browser#276
test plan: npm run test -- brave_browser_tests --filter=BraveWelcomeUIBrowserTest.*
@cezaraugusto cezaraugusto mentioned this issue Jun 22, 2018
Merged
bbondy pushed a commit to brave/brave-core that referenced this issue Jul 4, 2018
@cezaraugusto @bbondy
add about:welcome and webui handler
7be7400 
-
adds basic UI handler for welcome page without usable UI
while design finish the new spec for the page
-
address brave/brave-browser#276
test plan: npm run test -- brave_browser_tests --filter=BraveWelcomeUIBrowserTest.*
bbondy pushed a commit to brave/brave-core that referenced this issue Jul 5, 2018
@cezaraugusto @bbondy
add about:welcome and webui handler
76c6f39 
-
adds basic UI handler for welcome page without usable UI
while design finish the new spec for the page
-
address brave/brave-browser#276
test plan: npm run test -- brave_browser_tests --filter=BraveWelcomeUIBrowserTest.*
cezaraugusto added a commit to brave/brave-core that referenced this issue Jul 13, 2018
@cezaraugusto
add interface for built-in welcome page
9fd8abe 
closes brave/brave-browser#276
cezaraugusto added a commit to brave/brave-core that referenced this issue Jul 13, 2018
@cezaraugusto
add interface for built-in welcome page
abbc8ad 
closes brave/brave-browser#276
@cezaraugusto cezaraugusto mentioned this issue Jul 13, 2018
Merged
cezaraugusto added a commit to brave/brave-core that referenced this issue Jul 13, 2018
@cezaraugusto
add interface for built-in welcome page
7b29fc1 
closes brave/brave-browser#276
@bbondy bbondy removed this from Cezar Augusto in 0.55.x - Release Jul 23, 2018
@bbondy bbondy added the QA/Yes label Aug 18, 2018
@bbondy
Copy link
Member Author

bbondy commented Aug 18, 2018

QA notes:
Please completely test the welcome page in this issue.

@srirambv
Copy link
Contributor

srirambv commented Sep 21, 2018 •
edited by LaurenWags

Verification Passed on

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Linux
  • Verified first launch showed chrome://welcome
  • Verified manually typing chrome://welcome loads the welcome page
  • Verified Skip welcome tour loads chrome://newtab but doesnt retain the URL
  • Verified clicking on Lets Go opens the next screen
  • Verified Enable Rewards opens up chrome://rewards on the same tab
  • Verified Import No opens up chrome://settings/ImportData in a new tab
  • Verified clicking on Preferences loads chrome://settings on the same tab
  • Verified clicking Done loads chrome://newtab without the URL and focus is set to the URL bar
Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Windows 7

Verified passed with

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Mac OS X
  • Verified first launch showed chrome://welcome
  • Verified manually typing chrome://welcome loads the welcome page
  • Verified Skip welcome tour loads chrome://newtab but doesnt retain the URL
  • Verified clicking on Lets Go opens the next screen
  • Verified Enable Rewards opens up chrome://rewards on the same tab
  • Verified Import No opens up chrome://settings/ImportData in a new tab
  • Verified clicking on Preferences loads chrome://settings on the same tab
  • Verified clicking Done loads chrome://newtab without the URL and focus is set to the URL bar

@bbondy bbondy added the QA/Yes label Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cezaraugusto cezaraugusto

Labels
about-pages/welcome feature/brave-pages QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

3 commits they don't want you to know about the brand new welcome screen brave/brave-core
5 participants
@bbondy @cezaraugusto @srirambv @LaurenWags @btlechowski