Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

sometimes Brave crashes when closing #12939

Closed
LaurenWags opened this issue Jan 30, 2018 · 3 comments · Fixed by #12942
Closed

sometimes Brave crashes when closing #12939

LaurenWags opened this issue Jan 30, 2018 · 3 comments · Fixed by #12942

Comments

@LaurenWags
Copy link
Member

Description

Sometimes after closing Brave, the 'Brave unexpectedly quit' message displays.

Steps to Reproduce

  1. Use Brave normally.
  2. Quit Brave.

Actual result:
Sometimes Brave crashes when closing.

Expected result:
Brave should not crash on close.

Reproduces how often:
Unknown

Brave Version

about:brave info:
Brave | 0.20.27
V8 | 6.4.388.40
rev | 76102c5
Muon | 4.7.9
OS Release | 16.7.0
Update Channel | Release
OS Architecture | x64
OS Platform | macOS
Node.js | 7.9.0
Brave Sync | v1.4.2
libchromiumcontent | 64.0.3282.119

Reproducible on current live release:
Possibly, also unknown

Additional Information

@LaurenWags LaurenWags added bug crash 0.20.x issue first seen in 0.20.x labels Jan 30, 2018
@LaurenWags LaurenWags added this to the 0.20.x (Release Channel) milestone Jan 30, 2018
@bridiver
Copy link
Collaborator

this particular crash is a downstream effect of a problem with urlParse in the filtering code

@kjozwiak
Copy link
Member

@bridiver could you provide a test case that can be used for verification? Would using @LaurenWags's profile that reproduced this crash be sufficient enough?

@LaurenWags
Copy link
Member Author

LaurenWags commented Jan 31, 2018

Using profile that initially had the crashes I am still seeing some crashes on close with 0.20.29. Logged #12957 to address this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants