Improvements to about:passwords #13793
Comments
about:passwords should also not show usernames/emails, and instead have a slider like this one Just an idea. |
I think MacOS use Preferences while Windows and Linux use Settings if I'm not wrong? And |
Yes, the directions are accurate for Mac, but not for Windows and Linux because the option reads "Settings" instead. Seems like an easy fix, but what about localization? I think we'd have to create a new string (or more) for Windows and Linux? For example: |
How's this approach?
passwords.properties:
|
@jevuu Looks pretty good; though I suspect we have a variable someplace that could replace the explicit
@bsclifton Thoughts on this approach? |
Cool. I'll look through it and see if there is a variable for that. Is it alright if I submit a pull request and continue the discussion there, or should I wait for a response? |
Fixes brave#13793 * Changed password.js and passwords.properties Modified strings for password.properties. Added link in passwords.js to go to preferences#security * Additional changes passwords.properties and passwords.js passwords.js - changed label to span, added password.properties - removed space from end of string * Change hard-coded color to variable.
@jevuu you're always welcome to submit a PR (as you noticed 😄). Your PR was marked as work-in-progress... how's it going? |
Description
The page suggests users go to Preferences > Security to change how passwords are managed. Brave, however, doesn't have a Preference menu option. Instead, it should probably say Settings › Security.
Additionally, this should probably be a direct link to that resource, rather than directions.
Steps to Reproduce
Visit about:passwords in Brave.
Actual result:
Misleading, static text.
Expected result:
Hyperlink with accurate labeling.
Reproduces how often:
100%
Brave Version
0.22.13
about:brave info:
Reproducible on current live release:
Yes
The text was updated successfully, but these errors were encountered: