Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

bookmarks toolbar does not reduce in height in text-only mode #13985

Closed
petemill opened this issue May 2, 2018 · 1 comment
Closed

bookmarks toolbar does not reduce in height in text-only mode #13985

petemill opened this issue May 2, 2018 · 1 comment
Assignees
@petemill
Labels
0.22.x issue first seen in 0.22.x QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude
Milestone
0.22.x Release 3 ...

Comments

@petemill
Copy link
Member

petemill commented May 2, 2018 •
edited by bsclifton

Test plan

See #13986

Description

#13758 introduced fixed height on bookmarks bar to ensure it did not wrap to two lines. Looks like (possibly intentionaly) text-only mode in current release, the bar is a couple pixels shorter.

0.22.700
@petemill petemill added regression 0.22.x issue first seen in 0.22.x labels May 2, 2018
@petemill petemill added this to the 0.22.x Release 3 (Beta channel) milestone May 2, 2018
@petemill petemill self-assigned this May 2, 2018
petemill added a commit that referenced this issue May 2, 2018
@petemill
Ensure all icons in bookmarks bar are vertically aligned
fe85850 
Fix #13789

Also restore different bookmarks bar height when in text-only mode vs with favicons.
Fix #13985

Also reduce flicker of bookmark bar / overflow-indicator / last item by having aphrodite not remove the custom class-name on render.
@petemill petemill mentioned this issue May 2, 2018
Merged
10 tasks
petemill added a commit that referenced this issue May 2, 2018
@petemill
Ensure all icons in bookmarks bar are vertically aligned
9306021 
Fix #13789

Also restore different bookmarks bar height when in text-only mode vs with favicons.
Fix #13985

Also reduce flicker of bookmark bar / overflow-indicator / last item by having aphrodite not remove the custom class-name on render.
petemill added a commit that referenced this issue May 3, 2018
@petemill
Ensure all icons in bookmarks bar are vertically aligned
681349d 
Fix #13789

Also restore different bookmarks bar height when in text-only mode vs with favicons.
Fix #13985

Reduce flicker of bookmark bar / overflow-indicator / last item by having aphrodite not remove the custom class-name on render.

Reduce complexity of bookmarks toolbar state by passing through ToolbarMode 'enum' to component.
Future-proof bookmark mode setting retrieval for state-selector-memoization by passing through appState
This was referenced May 8, 2018
Closed
Closed
Closed
@btlechowski
Copy link
Contributor

btlechowski commented May 8, 2018 •
edited by LaurenWags

Verified on Ubuntu 17.10 x64
0.22.703 903b8d0
libchromiumcontent 66.0.3359.139
muon: 6.0.8

Verified on Windows x64

  • 0.22.703 903b8d0
  • libchromiumcontent 66.0.3359.139
  • muon: 6.0.8

Verified with macOS 10.12.6 using

  • 0.22.703 903b8d0
  • muon 6.0.8
  • libchromiumcontent 66.0.3359.139

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@petemill petemill

Labels
0.22.x issue first seen in 0.22.x QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude
Projects
None yet
Milestone
0.22.x Release 3 (Release Channel)
Development

No branches or pull requests
6 participants
@petemill @kjozwiak @bsclifton @srirambv @LaurenWags @btlechowski