Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

redo Tor newtab UI to remove Tor logo #14121

Closed
diracdeltas opened this issue May 14, 2018 · 4 comments
Closed

redo Tor newtab UI to remove Tor logo #14121

diracdeltas opened this issue May 14, 2018 · 4 comments
Assignees
@diracdeltas @bradleyrichter
Labels
feature/tor QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.23.x (Release C...

Comments

@diracdeltas
Copy link
Member

diracdeltas commented May 14, 2018 •
edited

also need to add '/' at the end of the url: https://torproject.org/

test plan:

  1. open new tor tab
  2. it shouldn't show the Tor onion logo, instead showing an eye logo
@diracdeltas diracdeltas added the needs-mockup A feature which needs design mockup to be implemented. label May 14, 2018
@diracdeltas diracdeltas added this to the 0.23.x (Developer Channel) milestone May 14, 2018
diracdeltas added a commit that referenced this issue May 17, 2018
@diracdeltas
Update to new extra-private icon
a93cfd4 
fix #14121
diracdeltas added a commit that referenced this issue May 17, 2018
@diracdeltas
Add slash to end of torproject URL
5a73788 
fix #14121
@diracdeltas
Copy link
Member Author

fixed by a93cfd4 and 5a73788

diracdeltas added a commit that referenced this issue May 22, 2018
@diracdeltas
Styling fixes based on david's feedback
ac1a024 
and add slash to end of torproject URL

fix #14121
diracdeltas added a commit that referenced this issue May 22, 2018
@diracdeltas
Update to new extra-private icon
ab2cd01 
fix #14121
diracdeltas added a commit that referenced this issue Jun 8, 2018
@diracdeltas
Styling fixes based on david's feedback
0edef74 
and add slash to end of torproject URL

fix #14121
diracdeltas added a commit that referenced this issue Jun 8, 2018
@diracdeltas
Update to new extra-private icon
4710683 
fix #14121
diracdeltas added a commit that referenced this issue Jun 12, 2018
@diracdeltas
Styling fixes based on david's feedback
6147218 
and add slash to end of torproject URL

fix #14121
diracdeltas added a commit that referenced this issue Jun 12, 2018
@diracdeltas
Update to new extra-private icon
8c11b15 
fix #14121
petemill pushed a commit that referenced this issue Jun 15, 2018
@diracdeltas @petemill
Styling fixes based on david's feedback
0d9488a 
and add slash to end of torproject URL

fix #14121
petemill pushed a commit that referenced this issue Jun 15, 2018
@diracdeltas @petemill
Update to new extra-private icon
11d9d20 
fix #14121
This was referenced Jun 19, 2018
Closed
Closed
Closed
@kjozwiak
Copy link
Member

@diracdeltas @bradleyrichter there isn't much information here for QA. I'm assuming the old design included the Tor logo under about:newtab for PT's which has been removed. Can you please confirm that this is the current design:

screen shot 2018-06-20 at 12 00 48 pm

Once confirmed, I'll quickly create a test plan in the original issue and tag this issue as QA/test-plan-specified.

This was referenced Jun 21, 2018
Closed
Closed
@srirambv srirambv mentioned this issue Jun 21, 2018
Closed
bsclifton pushed a commit that referenced this issue Jun 21, 2018
@diracdeltas @bsclifton
Styling fixes based on david's feedback
265749a 
and add slash to end of torproject URL

fix #14121
bsclifton pushed a commit that referenced this issue Jun 21, 2018
@diracdeltas @bsclifton
Update to new extra-private icon
1a8bc35 
fix #14121
bsclifton pushed a commit that referenced this issue Jun 21, 2018
@diracdeltas @bsclifton
Styling fixes based on david's feedback
76d3953 
and add slash to end of torproject URL

fix #14121
bsclifton pushed a commit that referenced this issue Jun 21, 2018
@diracdeltas @bsclifton
Update to new extra-private icon
bcbad3b 
fix #14121
This was referenced Jun 21, 2018
Closed
Closed
Closed
@diracdeltas diracdeltas removed QA/test-plan-required needs-mockup A feature which needs design mockup to be implemented. labels Jun 21, 2018
@rossmoody
Copy link
Contributor

@kjozwiak I've been working on this screen quite a bit and can confirm there is no Tor branding elements anywhere except for the fav.ico in regular type reading "Tor" in the tab when it's enabled

bsclifton pushed a commit that referenced this issue Jun 22, 2018
@diracdeltas @bsclifton
Styling fixes based on david's feedback
046943a 
and add slash to end of torproject URL

fix #14121
bsclifton pushed a commit that referenced this issue Jun 22, 2018
@diracdeltas @bsclifton
Update to new extra-private icon
2c0ad00 
fix #14121
@kjozwiak
Copy link
Member

kjozwiak commented Jun 22, 2018 •
edited by btlechowski

Verified on macOS 10.13.4 x64 using the following build:

  • 0.23.12 88f6f07
  • muon: 7.1.1
  • libchromiumcontent: 67.0.3396.87

Verified on Ubuntu 17.10 x64

  • 0.23.14 - f4da855
  • Muon - 7.1.1
  • libchromiumcontent - 67.0.3396.87

diracdeltas added a commit that referenced this issue Jun 22, 2018
@diracdeltas
Styling fixes based on david's feedback
548715f 
and add slash to end of torproject URL

fix #14121
diracdeltas added a commit that referenced this issue Jun 22, 2018
@diracdeltas
Update to new extra-private icon
67480f6 
fix #14121
bsclifton pushed a commit that referenced this issue Jun 23, 2018
@diracdeltas @bsclifton
Styling fixes based on david's feedback
ab4254b 
and add slash to end of torproject URL

fix #14121
bsclifton pushed a commit that referenced this issue Jun 23, 2018
@diracdeltas @bsclifton
Update to new extra-private icon
d27c598 
fix #14121
bsclifton pushed a commit that referenced this issue Jun 25, 2018
@diracdeltas @bsclifton
Styling fixes based on david's feedback
68e79be 
and add slash to end of torproject URL

fix #14121
bsclifton pushed a commit that referenced this issue Jun 25, 2018
@diracdeltas @bsclifton
Update to new extra-private icon
99904e8 
fix #14121
bsclifton pushed a commit that referenced this issue Jun 26, 2018
@diracdeltas @bsclifton
Styling fixes based on david's feedback
2826b55 
and add slash to end of torproject URL

fix #14121
bsclifton pushed a commit that referenced this issue Jun 26, 2018
@diracdeltas @bsclifton
Update to new extra-private icon
7974557 
fix #14121
bsclifton pushed a commit that referenced this issue Jun 27, 2018
@diracdeltas @bsclifton
Styling fixes based on david's feedback
afe8ad3 
and add slash to end of torproject URL

fix #14121
bsclifton pushed a commit that referenced this issue Jun 27, 2018
@diracdeltas @bsclifton
Update to new extra-private icon
fd8174b 
fix #14121
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@diracdeltas diracdeltas

@bradleyrichter bradleyrichter

Labels
feature/tor QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.23.x (Release Channel)
Development

No branches or pull requests
8 participants
@diracdeltas @tildelowengrimm @kjozwiak @bradleyrichter @srirambv @LaurenWags @rossmoody @btlechowski