Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

change styling of box outline and fonts in private tabs page #14167

Closed
bradleyrichter opened this issue May 17, 2018 · 12 comments
Closed

change styling of box outline and fonts in private tabs page #14167

bradleyrichter opened this issue May 17, 2018 · 12 comments

Comments

@bradleyrichter
Copy link
Contributor

bradleyrichter commented May 17, 2018

Test Plan

  • Open a PT using a 0.23.x build that has Tor integrated
  • ensure that the PT tab under brave matches the proposed design/style mentioned below.

Original issue

current:

image

proposed:

image

needs: CSS replacent

@bradleyrichter bradleyrichter added design A design change, especially one which needs input from the design team. feature/tor labels May 17, 2018
@bradleyrichter bradleyrichter added this to the 0.23.x (Developer Channel) milestone May 17, 2018
@bradleyrichter bradleyrichter changed the title change styling of box outline in private tabs page change styling of box outline and fonts in private tabs page May 17, 2018
@diracdeltas
Copy link
Member

@rossmoody are you doing the restyling? if so you should work off of the tor/0.23.x branch

note that the 'Learn more...' text should be kept even though it's missing in the mockup

@rossmoody
Copy link
Contributor

I'm getting up to speed on git process and this is my trial ticket Brad's helping me with. I'm going to attempt a restyling of sorts here but ty for the heads up on both fronts there.

@diracdeltas
Copy link
Member

@rossmoody cool. FYI the object you will want to edit is styles in js/about/newprivatetab.js

diracdeltas pushed a commit that referenced this issue May 22, 2018
Fixes #14167

- Updated svg icon code to larger consistent size
- Updated padding and margins
- Center justified private tab setting content
- Condensed private tab descriptor paragraphs at footer
- Updated styling of boxes to horizontal rules
@diracdeltas
Copy link
Member

fixed by 4ebc04b

diracdeltas pushed a commit that referenced this issue Jun 8, 2018
Fixes #14167

- Updated svg icon code to larger consistent size
- Updated padding and margins
- Center justified private tab setting content
- Condensed private tab descriptor paragraphs at footer
- Updated styling of boxes to horizontal rules
diracdeltas pushed a commit that referenced this issue Jun 12, 2018
Fixes #14167

- Updated svg icon code to larger consistent size
- Updated padding and margins
- Center justified private tab setting content
- Condensed private tab descriptor paragraphs at footer
- Updated styling of boxes to horizontal rules
petemill pushed a commit that referenced this issue Jun 15, 2018
Fixes #14167

- Updated svg icon code to larger consistent size
- Updated padding and margins
- Center justified private tab setting content
- Condensed private tab descriptor paragraphs at footer
- Updated styling of boxes to horizontal rules
@kjozwiak
Copy link
Member

kjozwiak commented Jun 20, 2018

Verified on macOS 10.13.4 x64 using the following build:

  • 0.23.11 6565c06
  • muon: 7.1.0
  • libchromiumcontent: 67.0.3396.87

Example:

screen shot 2018-06-22 at 12 14 18 am

@kjozwiak
Copy link
Member

@bradleyrichter the current text differs from the proposed screenshot in the original comment. Can you please confirm that the one I added above is the expected text/design?

bsclifton pushed a commit that referenced this issue Jun 21, 2018
Fixes #14167

- Updated svg icon code to larger consistent size
- Updated padding and margins
- Center justified private tab setting content
- Condensed private tab descriptor paragraphs at footer
- Updated styling of boxes to horizontal rules
bsclifton pushed a commit that referenced this issue Jun 21, 2018
Fixes #14167

- Updated svg icon code to larger consistent size
- Updated padding and margins
- Center justified private tab setting content
- Condensed private tab descriptor paragraphs at footer
- Updated styling of boxes to horizontal rules
bsclifton pushed a commit that referenced this issue Jun 22, 2018
Fixes #14167

- Updated svg icon code to larger consistent size
- Updated padding and margins
- Center justified private tab setting content
- Condensed private tab descriptor paragraphs at footer
- Updated styling of boxes to horizontal rules
@kjozwiak
Copy link
Member

We're still not using the summary that @bradleyrichter proposed in the original comment. With the latest 0.23.12 88f6f07 build, we're still using the following summary which isn't the one that's being proposed:

screen shot 2018-06-22 at 12 23 46 am

@bradleyrichter @jenn-rhim is this expected?

@bradleyrichter
Copy link
Contributor Author

this needs to defer to @flamsmark and @mandar-brave because it has changed a few times since the original screen shot that has become git-stale.

@diracdeltas
Copy link
Member

@bradleyrichter i can confirm this is using the latest text that @flamsmark drafted (to the best of my knowledge)

@bradleyrichter
Copy link
Contributor Author

ok. And it looks fine to me anyway.

cc @kjozwiak

diracdeltas pushed a commit that referenced this issue Jun 22, 2018
Fixes #14167

- Updated svg icon code to larger consistent size
- Updated padding and margins
- Center justified private tab setting content
- Condensed private tab descriptor paragraphs at footer
- Updated styling of boxes to horizontal rules
@kjozwiak
Copy link
Member

Thanks @bradleyrichter @diracdeltas 👍

@srirambv @btlechowski @GeetaSarvadnya looks like what we're currently seeing is the correct text.

@kjozwiak
Copy link
Member

kjozwiak commented Jun 23, 2018

Verified using macOS 10.13.4 x64 using the following build:

  • 0.23.14 f4da855
  • muon: 7.1.1
  • libchromiumcontent: 67.0.3396.87

Verified on Windows 10 x64 using

  • `0.23.14 f4da855
  • Muon - 7.1.1
  • libchromiumcontent - 67.0.3396.87

Verified on Ubuntu 18.04 x64 using the following build:

  • 0.23.17 bc754eb
  • muon: 7.1.2
  • libchromiumcontent: 67.0.3396.87

bsclifton pushed a commit that referenced this issue Jun 23, 2018
Fixes #14167

- Updated svg icon code to larger consistent size
- Updated padding and margins
- Center justified private tab setting content
- Condensed private tab descriptor paragraphs at footer
- Updated styling of boxes to horizontal rules
bsclifton pushed a commit that referenced this issue Jun 25, 2018
Fixes #14167

- Updated svg icon code to larger consistent size
- Updated padding and margins
- Center justified private tab setting content
- Condensed private tab descriptor paragraphs at footer
- Updated styling of boxes to horizontal rules
bsclifton pushed a commit that referenced this issue Jun 26, 2018
Fixes #14167

- Updated svg icon code to larger consistent size
- Updated padding and margins
- Center justified private tab setting content
- Condensed private tab descriptor paragraphs at footer
- Updated styling of boxes to horizontal rules
bsclifton pushed a commit that referenced this issue Jun 27, 2018
Fixes #14167

- Updated svg icon code to larger consistent size
- Updated padding and margins
- Center justified private tab setting content
- Condensed private tab descriptor paragraphs at footer
- Updated styling of boxes to horizontal rules
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants