Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Add too many requests overlay #14356

Closed
NejcZdovc opened this issue Jun 8, 2018 · 1 comment
Closed

Add too many requests overlay #14356

NejcZdovc opened this issue Jun 8, 2018 · 1 comment

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Jun 8, 2018

Test Plan

Case 1:

  1. Enable payments via about:preferences#payments
  2. Claim grant by clicking on Claim my free tokens
  3. Intentionally miss CAPTCHA 50 times
  4. Ensure that you receive the message outlined under Expected results
  5. Start a timer for 3 hours once you're ip has been blocked
  6. After 3 hours, ensure that you can re-attempt CAPTCHA and successfully claim a grant

Case 2:

  1. Click on Claim my free tokens (ensure that you're ip has been blocked in Case 1)
  2. Ensure that you don't receive a CAPTCHA and the error message outlined under Expected results is being displayed instead.

Case 3:

  1. Click on Claim my free tokens (ensure that you're ip has been blocked in Case 1)
  2. Ensure that you can dismiss the message by pressing X and Ok

Case 4:

  1. Click on Claim my free tokens (ensure that you're ip has been blocked in Case 1)
  2. Go into about:preferences#payments and disable/enable Payments
  3. Click on Claim my free tokens and ensure you're still getting an error message

Case 5:

  1. Click on Claim my free tokens (ensure that you're ip has been blocked in Case 1)
  2. Restart Brave
  3. Click on Claim my free tokens and ensure you're still getting an error message

Case 6:

  1. Click on Claim my free tokens (ensure that you're ip has been blocked in Case 1)
  2. Select Advanced Settings under about:preferences#payments
  3. Delete your wallet using Delete wallet
  4. Enable Payments again to create a new wallet via about:preferences#payments
  5. Click on Claim my free tokens and ensure you're still getting an error message

Case 7:

  1. Click on Claim my free tokens (ensure that you're ip has been blocked in Case 1)
  2. Send a small amount of BAT into your wallet and ensure you end up receiving the funds
  3. Ensure that you can still add publishers into the ledger table

Description

We would like to show notification to the users who tried captcha too many times.

Steps to Reproduce

Case 1:

  1. Enable payments via about:preferences#payments
  2. Claim grant by clicking on Claim my free tokens
  3. Intentionally miss CAPTCHA 50 times

Actual result:

You get general error

Expected result:
You should get

image

Reproduces how often:

Brave Version

about:brave info:

Reproducible on current live release:

Additional Information

@NejcZdovc NejcZdovc self-assigned this Jun 8, 2018
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jun 8, 2018
Resolves brave#14356

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jun 8, 2018
Resolves brave#14356

Auditors:

Test Plan:
NejcZdovc added a commit that referenced this issue Jun 8, 2018
NejcZdovc added a commit that referenced this issue Jun 8, 2018
NejcZdovc added a commit that referenced this issue Jun 8, 2018
@LaurenWags
Copy link
Member

LaurenWags commented Jun 8, 2018

Verified with macOS 10.12.6 using

  • 0.22.808 2572bd3
  • Muon 7.0.4
  • libchromiumcontent 67.0.3396.71

Verified on Win 10 x64 using the following build:

  • 0.22.808 2572bd3
  • muon: 7.0.4
  • libchromiumcontent 67.0.3396.71

Verified on Ubuntu 17.10 x64

  • 0.22.808 2572bd3
  • Muon 7.0.4
  • libchromiumcontent 67.0.3396.71

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.