Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Torrent/Magnet link should show unsupported message on TOR tab #14374

Closed
GeetaSarvadnya opened this issue Jun 11, 2018 · 4 comments
Closed

Torrent/Magnet link should show unsupported message on TOR tab #14374

GeetaSarvadnya opened this issue Jun 11, 2018 · 4 comments
Assignees
@jumde
Labels
feature/tor priority/P4 Minor loss of function. Workaround usually present. QA/checked-Linux QA/checked-macOS QA/checked-Win64 release-notes/exclude
Milestone
0.23.x (Release C...

Comments

@GeetaSarvadnya
Copy link
Collaborator

GeetaSarvadnya commented Jun 11, 2018 •
edited

Description

Torrent file and magnet links are redirecting to empty TOR pages, there is no message indication to state that the page cannot be displayed

Steps to Reproduce

  1. Enable TOR
  2. Open the link in private tor tab https://webtorrent.io/free-torrents
  3. Open the links (torrent file) (magnet link) in private tab

Actual result:
Torrent file and magnet links are redirecting to empty TOR pages there is no message indication to state that the page cannot be displayed

image

Expected result:
Page should be displayed with appropriate message.

Reproduces how often:
Easy

Brave Version

0.23.8

Reproducible on current live release:

Additional Information
@GeetaSarvadnya GeetaSarvadnya added priority/P4 Minor loss of function. Workaround usually present. feature/tor labels Jun 11, 2018
@GeetaSarvadnya GeetaSarvadnya changed the title Torrent file and magnet links are redirecting to empty TOR pages there is no message indication to state that the page cannot be displayed Torrent file and magnet links are redirecting to empty TOR pages, there is no message indication to state that the page cannot be displayed Jun 11, 2018
@diracdeltas
Copy link
Member

We disable torrent content in Tor for privacy reasons, so it should probably show some kind of error message ("Torrent cannot be loaded over Tor for privacy reasons.")

@jumde jumde self-assigned this Jun 11, 2018
@srirambv srirambv changed the title Torrent file and magnet links are redirecting to empty TOR pages, there is no message indication to state that the page cannot be displayed Torrent/Magnet link should show unsupported message on TOR tab Jun 11, 2018
jumde added a commit that referenced this issue Jun 11, 2018
@jumde
Fixes: #14374 Show warning if torrent files are opened in tor private…
fc2c229 
… tabs
@jumde jumde mentioned this issue Jun 11, 2018
Merged
jumde added a commit that referenced this issue Jun 11, 2018
@jumde
Fixes: #14374 Show warning if torrent files are opened in tor private…
dcb0ff8 
… tabs
jumde added a commit that referenced this issue Jun 11, 2018
@jumde
Fixes: #14374 Show warning if torrent files are opened in tor private…
3b5cecd 
… tabs
jumde added a commit that referenced this issue Jun 12, 2018
@jumde
Fixes: #14374 Show warning if torrent files are opened in tor private…
51caf52 
… tabs
@diracdeltas
Copy link
Member

fixed by 51caf52

diracdeltas pushed a commit that referenced this issue Jun 12, 2018
@jumde @diracdeltas
Fixes: #14374 Show warning if torrent files are opened in tor private…
3874337 
… tabs
petemill pushed a commit that referenced this issue Jun 15, 2018
@jumde @petemill
Fixes: #14374 Show warning if torrent files are opened in tor private…
ab4bb33 
… tabs
@srirambv
Copy link
Collaborator

srirambv commented Jun 20, 2018 •
edited

@bsclifton @diracdeltas This doesn't seem to be included in 0.23.11. I still see empty tab without any warning when opening a torrent in Tor tab.

Edit: Testing on a new profile shows the error message

@srirambv srirambv mentioned this issue Jun 20, 2018
Closed
This was referenced Jun 21, 2018
Closed
Closed
Closed
bsclifton pushed a commit that referenced this issue Jun 21, 2018
@jumde @bsclifton
Fixes: #14374 Show warning if torrent files are opened in tor private…
5be86a7 
… tabs
bsclifton pushed a commit that referenced this issue Jun 21, 2018
@jumde @bsclifton
Fixes: #14374 Show warning if torrent files are opened in tor private…
1d378a4 
… tabs
This was referenced Jun 21, 2018
Closed
Closed
Closed
@srirambv
Copy link
Collaborator

srirambv commented Jun 21, 2018 •
edited by btlechowski

Verified on Windows 10 x64 using

  • 0.23.12 - 88f6f07
  • Muon - 7.1.1
  • libchromiumcontent - 67.0.3396.87

Verified with macOS 10.12.6 using

  • 0.23.14 f4da855
  • Muon 7.1.1
  • libchromiumcontent 67.0.3396.87
    screen shot 2018-06-22 at 11 35 53 am

Verified on Ubuntu 17.10 x64

  • 0.23.14 - f4da855
  • Muon - 7.1.1
  • libchromiumcontent - 67.0.3396.87

bsclifton pushed a commit that referenced this issue Jun 22, 2018
@jumde @bsclifton
Fixes: #14374 Show warning if torrent files are opened in tor private…
53b0e06 
… tabs
diracdeltas pushed a commit that referenced this issue Jun 22, 2018
@jumde @diracdeltas
Fixes: #14374 Show warning if torrent files are opened in tor private…
4e207bc 
… tabs
bsclifton pushed a commit that referenced this issue Jun 23, 2018
@jumde @bsclifton
Fixes: #14374 Show warning if torrent files are opened in tor private…
aeba14b 
… tabs
bsclifton pushed a commit that referenced this issue Jun 25, 2018
@jumde @bsclifton
Fixes: #14374 Show warning if torrent files are opened in tor private…
0e8c70c 
… tabs
bsclifton pushed a commit that referenced this issue Jun 26, 2018
@jumde @bsclifton
Fixes: #14374 Show warning if torrent files are opened in tor private…
cfd722d 
… tabs
bsclifton pushed a commit that referenced this issue Jun 27, 2018
@jumde @bsclifton
Fixes: #14374 Show warning if torrent files are opened in tor private…
9b5b9d7 
… tabs
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jumde jumde

Labels
feature/tor priority/P4 Minor loss of function. Workaround usually present. QA/checked-Linux QA/checked-macOS QA/checked-Win64 release-notes/exclude
Projects
None yet
Milestone
0.23.x (Release Channel)
Development

No branches or pull requests
5 participants
@diracdeltas @jumde @srirambv @btlechowski @GeetaSarvadnya