Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Bookmark modal alignment is off when home button is enabled/disabled #14456

Closed
srirambv opened this issue Jun 19, 2018 · 2 comments
Closed

Bookmark modal alignment is off when home button is enabled/disabled #14456

srirambv opened this issue Jun 19, 2018 · 2 comments
Assignees
@petemill
Labels
0.23.x issue first seen in 0.23.x design A design change, especially one which needs input from the design team. feature/bookmarks QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude
Milestone
0.23.x (Release C...

Comments

@srirambv
Copy link
Collaborator

srirambv commented Jun 19, 2018 •
edited by bsclifton

Description

Bookmark modal alignment is off when home button is enabled/disabled

Test plan / Steps to Reproduce

  1. Enable home button from settings
  2. Add bookmark, modal shows under the URL bar
  3. Disable home button from settings
  4. Add bookmark, hanger is shown

Actual result:
Hanger shows under bookmark icon but is off to the left
bookmarks

Expected result:
Hanger/Modal should be under the bookmark icon irrespective of home button enabled/disabled

Reproduces how often:
100%

Brave Version

about:brave info:

Brave 0.23.11
V8 6.7.288.46
rev 6565c06
Muon 7.1.0
OS Release 10.0.17134
Update Channel Beta
OS Architecture x64
OS Platform Microsoft Windows
Node.js 7.9.0
Brave Sync v1.4.2
libchromiumcontent 67.0.3396.87

Reproducible on current live release:
No

Additional Information
@srirambv srirambv added design A design change, especially one which needs input from the design team. feature/bookmarks regression labels Jun 19, 2018
@srirambv srirambv added this to the 0.23.x (Beta Channel) milestone Jun 19, 2018
@kjozwiak
Copy link
Member

kjozwiak commented Jun 19, 2018 •
edited

Reproducible on macOS 10.13.4 x64 using 0.23.11 6565c06 using the above STR, example:

screen shot 2018-06-19 at 3 13 24 pm

petemill added a commit that referenced this issue Jun 21, 2018
@petemill
Adjust bookmark hanger position to match bookmark button
3fe1f8e 
Fix #14456

The position of the icon had changed relative to the container. Futhermore, the home button being shown / not shown no longer affects the positioning of the bookmark hanger since it is not within the same container anymore.
@petemill petemill mentioned this issue Jun 21, 2018
Merged
10 tasks
This was referenced Jun 22, 2018
Closed
Closed
Closed
@LaurenWags
Copy link
Member

LaurenWags commented Jun 22, 2018 •
edited by srirambv

Verified with macOS 10.12.6 using

  • 0.23.14 f4da855
  • Muon 7.1.1
  • libchromiumcontent 67.0.3396.87

Verified on Ubuntu 17.10 x64

  • 0.23.14 - f4da855
  • Muon - 7.1.1
  • libchromiumcontent - 67.0.3396.87

Verified on Windows 10 x64

  • 0.23.14 - f4da855
  • Muon - 7.1.1
  • libchromiumcontent - 67.0.3396.87

@kjozwiak kjozwiak added the 0.23.x issue first seen in 0.23.x label Jun 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@petemill petemill

Labels
0.23.x issue first seen in 0.23.x design A design change, especially one which needs input from the design team. feature/bookmarks QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude
Projects
None yet
Milestone
0.23.x (Release Channel)
Development

No branches or pull requests
6 participants
@petemill @kjozwiak @bsclifton @srirambv @LaurenWags @btlechowski