Visited links are not reset when closing Brave #14667
Comments
marking this as regression of #9351 |
Trying to reproduce:
I verified the patch that originally fixed this issue is in place (with our current Muon): |
@warwickmm are you using KDE by chance? Do you have more information about your setup? (distro, window manager version, etc) |
maybe the history delete callback in muon is not called before the browser shuts down? |
Sorry, I should have included more details about my setup in the description. I'm running Arch Linux with the Cinnamon desktop environment. |
I should perhaps mention that I also have an installation of Chromium on the machine. Not sure if that matters? |
Based on my results above, one intermittent case I didn't mention (browsing on KDE, closing Brave, opening in Gnome; links showed as visited - Ubuntu 14), and that @rebron was able to reproduce once (but not again), I think this might be exactly the case @diracdeltas is mentioning... which might be a race condition |
insert a small delay before shutdown on linux to ensure that the delete history muon callback finishes
Should be fixed with #15028 |
Test plan
Original issue description
Under Preferences -> Security -> Private Data, I have selected all data to be cleared when closing Brave. However, visited links are not reset when closing Brave. If I explicitly go to History -> Clear Browsing Data, then the visited links are reset.
Steps to Reproduce
Reproduces how often:
100%
Brave Version
Reproducible on current live release:
This is reproducible on version 0.23.19 (178c3fb)
This is reproducible on version 0.23.31 (3148ace)
This is reproducible on version 0.23.73 (50bdb6d)
Additional Information
This is related to issue #9351.
The text was updated successfully, but these errors were encountered: