disabling nav scroll when content is horizontally scrollable.

[TeoMorabito]

When I scroll horizontally on a website such as a calendar, scrolling sideways makes the page go back of forward in history.

If content is scrollable horizontally, nav scroll should be disabled, or at least a setting to disable it.

Using a retina macbook pro

@joelwass thank you for suggesting to open a new issue

[TeoMorabito]

Going into System Preference > Trackpad
and unchecking swipe between pages disables the swipe right and left gesture and thus disables the navigation swipe in brave.
(I am not able to swipe horizontally on a calendar so needed a way to disable it so it wouldn't go back and forth in the history)

This bypasses the issue, but doesn't fix the issue

[darkdh]

fixed by 69851d1

[LaurenWags]

@darkdh could you provide test steps for this? I tried shrinking my window so that the content within it was horizontally scrollable (gif below) but that didn't work (swiping left/right still navigates thru tab history). Unsure if I'm testing this the correct way?

[darkdh]

use page like https://github.com/orgs/brave/projects/7 with long horizontal content and shrink the window and you can swipe as hard as you can.
The gif you are showing is expected. When the horizontal content is short and you swipe hard that means swipe distance reaches the threshold easily. The most important thing to prevent is trigger navigation in the middle of scrolling. If it the page is at the edge and you reach the distance threshold, navigation happens.

[darkdh]

with the fix:

current release :

[LaurenWags]

Using site from #14871 (comment) and gifs from #14871 (comment) verified scrolling is improved with 0.23.205. cc @kjozwiak for a double check on macOS.

[kjozwiak]

Went through the original case that @darkdh mentioned in #14871 (comment) and ran into the issue right away using 0.23.107 6f2fc65 which is the current live release.

Using the following build on macOS 10.13.16 x64, I ensured that the above issue wasn't occurring using while using the different swipe settings under about:preferences#advanced:

• 0.23.206 80a5ac1
• Muon: 8.1.5
• libchromiumcontent: 69.0.3497.92