Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Drag-focusing the address bar should not select-all #2900

Closed
gulkily opened this issue Aug 3, 2016 · 2 comments
Closed

Drag-focusing the address bar should not select-all #2900

gulkily opened this issue Aug 3, 2016 · 2 comments
Labels
fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. polish Nice to have — usually related to front-end/visual tasks. wontfix

Comments

@gulkily
Copy link

gulkily commented Aug 3, 2016

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
Attempting to select part of the URL text in the address bar results in all text being selected (select-all) if the address bar did not previously have focus.

Expected behavior:
Selection should happen right away, so as to not annoy the user

  • Platform (Win7, 8, 10? macOS? Linux distro?): Tested on macOS
  • Brave Version: 0.11.1
  • Steps to reproduce:
    1. Open a page in Brave
    2. Mouse-over the title to display the address bar (but do not click it yet)
    3. Attempt to select text from the middle of the address bar text by clicking and dragging. For example, if the URL is "http://www.example.com/foo/bar/index.html", try to select just the "foo/bar" part.

Expected: The text the mouse cursor is dragged over is selected, but not the other parts of it

Actual: It seems like mouse-down on the address bar triggers a select-all, and the entire text ends up being selected. The beginning of the selection is then in the beginning of the text, and the end of the selection moves with the mouse cursor.

At other times, seemingly after I Alt-Tab to Brave, or maybe only when Jing is running and I'm trying to make a video of this bug, the entire address bar text ends up being dragged. Once I drop it back into the address bar, the page does some kind of refresh, although form data is not lost (thank goodness)

@bsclifton bsclifton added bug/good-first-bug polish Nice to have — usually related to front-end/visual tasks. labels Oct 24, 2016
@bsclifton bsclifton added this to the Triage Backlog milestone Nov 27, 2017
@jevuu
Copy link

jevuu commented Mar 20, 2018

Hello,

May I take on this issue?

@jevuu jevuu mentioned this issue Mar 26, 2018
10 tasks
jevuu added a commit to jevuu/browser-laptop that referenced this issue Mar 26, 2018
Modified url bar so that mouse down will not select all.
@NejcZdovc NejcZdovc added the help wanted The PR/issue opener needs help to complete/report the task. label May 7, 2018
@bsclifton bsclifton modified the milestones: Triage Backlog, Completed work Jul 22, 2018
@bsclifton bsclifton added wontfix fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. and removed bug/good-first-bug help wanted The PR/issue opener needs help to complete/report the task. labels Sep 1, 2018
@bsclifton bsclifton removed this from the Completed work milestone Sep 8, 2018
@bsclifton
Copy link
Member

Verified fixed with our Developer channel release 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. polish Nice to have — usually related to front-end/visual tasks. wontfix
Projects
None yet
Development

No branches or pull requests

4 participants