Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Feeling of panic immidiately on every start #3778

Closed
da2x opened this issue Sep 6, 2016 · 2 comments
Closed

Feeling of panic immidiately on every start #3778

da2x opened this issue Sep 6, 2016 · 2 comments
Assignees
@ayumi
Labels
feature/rewards QA/checked-Linux QA/checked-Win64
Milestone
0.12.1dev

Comments

@da2x
Copy link
Contributor

da2x commented Sep 6, 2016 •
edited

  1. Leave about:preferences#payments open
  2. Restart the browser and check the Payments page

Expected: account balance to display a cached value from the previous session until Brave has updated the currency exchange rates, etc.

Actual: account balance “0 USD” displayed for a few seconds and my heart skips a beat or two and I start thinking about whether I’ve backed up my Brave user data or not. After some seconds the correct value is displayed.
@da2x da2x mentioned this issue Sep 7, 2016
Closed
@bbondy bbondy added this to the 0.12.1dev milestone Sep 7, 2016
@mrose17
Copy link
Member

mrose17 commented Sep 7, 2016 •
edited

just checking: is this on linux? on a mac, i get a different behavior (viz., first i see the initialization screen and then the "real" screen). i agree that we need to fix this, but want to make sure i'm on the same page... looks to me that react is rendering the page before it gets the appData and that the wallet default is 0 rather than ...

@da2x
Copy link
Contributor Author

da2x commented Sep 7, 2016

This is on Linux. Don’t have any funds in Brave on my MacBook.

@ayumi ayumi self-assigned this Sep 7, 2016
ayumi added a commit that referenced this issue Sep 7, 2016
@ayumi
Show "loading" when payments balance is loading
09d03e5 
Fix #3778
Fix #3785 or at least a gentle fallback

Auditors: @diracdeltas @bbondy

Test Plan:

Offline case:
1. Disable internet
2. Re/open Brave
3. Open Preferences -> Payments
4. Observe that account balance is "loading..." and not 0

Online case:
1. Open Brave
2. Open Preferences -> Payments
3. Observe account balance is accurate
ayumi added a commit that referenced this issue Sep 7, 2016
@ayumi
Show "loading" when payments balance is loading
40b5072 
Fix #3778
Fix #3785 or at least a gentle fallback

Auditors: @diracdeltas @bbondy

Test Plan:

Offline case:
1. Disable internet
2. Re/open Brave
3. Open Preferences -> Payments
4. Observe that account balance is "loading..." and not 0

Online case:
1. Open Brave
2. Open Preferences -> Payments
3. Observe account balance is accurate
ayumi added a commit that referenced this issue Sep 8, 2016
@ayumi
Show "loading" when payments balance is loading
070aa76 
Fix #3778
Fix #3785 or at least a gentle fallback

Auditors: @diracdeltas @bbondy

Test Plan:

Offline case:
1. Disable internet
2. Re/open Brave
3. Open Preferences -> Payments
4. Observe that account balance is "loading..." and not 0

Online case:
1. Open Brave
2. Open Preferences -> Payments
3. Observe account balance is accurate
@ayumi ayumi mentioned this issue Sep 8, 2016
Merged
4 tasks
ayumi added a commit that referenced this issue Sep 8, 2016
@ayumi
Improve UX of unavailable ledger balance
3e1f025 
Fix #3778
Fix #3785 or at least a gentle fallback
ayumi added a commit that referenced this issue Sep 8, 2016
@ayumi
Improve UX of unavailable ledger balance
fffa903 
Fix #3778
Fix #3785 or at least a gentle fallback
This was referenced Sep 10, 2016
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@alexwykoff alexwykoff mentioned this issue Sep 15, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ayumi ayumi

Labels
feature/rewards QA/checked-Linux QA/checked-Win64
Projects
None yet
Milestone
0.12.1dev
Development

No branches or pull requests
6 participants
@mrose17 @ayumi @bbondy @da2x @alexwykoff @bsclifton