Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

js/lib/psl.js needs update #4136

Closed
diracdeltas opened this issue Sep 20, 2016 · 2 comments · Fixed by #5138
Closed

js/lib/psl.js needs update #4136

diracdeltas opened this issue Sep 20, 2016 · 2 comments · Fixed by #5138
Assignees
@diracdeltas
Labels
QA/no-qa-needed
Milestone
0.12.8dev

Comments

@diracdeltas
Copy link
Member

we are using the one from Privacy Badger for efficient base domain lookups but it seems to be out of date with https://raw.githubusercontent.com/publicsuffix/list/master/public_suffix_list.dat
@diracdeltas diracdeltas added this to the 0.12.3dev milestone Sep 20, 2016
@diracdeltas diracdeltas self-assigned this Sep 20, 2016
@diracdeltas
Copy link
Member Author

this is only used to do third-partiness checks on webRequests. now that i think about it, it's only needed for 3rd party cookie checking, which @bridiver says is moving to use Chromium internals anyway. other 3rd party checks can just do domain comparison.

@diracdeltas diracdeltas removed this from the 0.12.3dev milestone Sep 20, 2016
@diracdeltas diracdeltas changed the title update public suffix list js/lib/psl.js probably not necessary Sep 21, 2016
@diracdeltas diracdeltas changed the title js/lib/psl.js probably not necessary js/lib/psl.js needs update Oct 25, 2016
@diracdeltas
Copy link
Member Author

we can use https://github.com/EFForg/privacybadgerchrome/pull/970/files to add updating the PSL to the build process

@diracdeltas diracdeltas added this to the 0.12.8dev milestone Oct 25, 2016
diracdeltas added a commit that referenced this issue Oct 26, 2016
@diracdeltas
Update public suffix list
34f4fcf 
fix #4136 and add automated script for updating

Auditors: @bbondy

Test Plan: n/a
@diracdeltas diracdeltas mentioned this issue Oct 26, 2016
Merged
4 tasks
diracdeltas added a commit that referenced this issue Oct 26, 2016
@diracdeltas
Update public suffix list
c74ded9 
fix #4136 and add automated script for updating

Auditors: @bbondy

Test Plan: n/a
This was referenced Nov 2, 2016
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@diracdeltas diracdeltas

Labels
QA/no-qa-needed
Projects
None yet
Milestone
0.12.8dev
Development

Successfully merging a pull request may close this issue.

Update public suffix list brave/browser-laptop
2 participants
@diracdeltas @alexwykoff