Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Always check on startup option is too glued to the set as default... button #4935

Closed
bbondy opened this issue Oct 19, 2016 · 0 comments · Fixed by #4951
Closed

Always check on startup option is too glued to the set as default... button #4935

bbondy opened this issue Oct 19, 2016 · 0 comments · Fixed by #4951
Assignees
@darkdh
Labels
design A design change, especially one which needs input from the design team. QA/checked-Linux QA/checked-macOS QA/checked-Win64
Milestone
0.12.6dev

Comments

@bbondy
Copy link
Member

bbondy commented Oct 19, 2016

There needs to be some margin in between the set as default... button and the always check on startup startup, they look too glued together currently.

(Great work btw, it all works perfectly for me on mac)
@bbondy bbondy added this to the 0.12.6dev milestone Oct 19, 2016
@luixxiul luixxiul added the design A design change, especially one which needs input from the design team. label Oct 19, 2016
darkdh added a commit to darkdh/browser-laptop that referenced this issue Oct 19, 2016
@darkdh
Improve UX of default browser check and Manage Adblock Setting button
bb95747 
fix brave#4935

Auditors: @bbondy

Test Plan: N/A
@darkdh darkdh mentioned this issue Oct 19, 2016
Merged
4 tasks
This was referenced Oct 20, 2016
Closed
Closed
@alexwykoff alexwykoff mentioned this issue Oct 22, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
design A design change, especially one which needs input from the design team. QA/checked-Linux QA/checked-macOS QA/checked-Win64
Projects
None yet
Milestone
0.12.6dev
Development

Successfully merging a pull request may close this issue.

Improve UX of default browser check and Manage Adblock Setting button darkdh/browser-laptop
5 participants
@bbondy @alexwykoff @luixxiul @darkdh @srirambv