Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

1Password and LastPass repeated entries in right click context menu #5291

Closed
srirambv opened this issue Oct 31, 2016 · 0 comments · Fixed by #5298
Closed

1Password and LastPass repeated entries in right click context menu #5291

srirambv opened this issue Oct 31, 2016 · 0 comments · Fixed by #5298
Assignees
@darkdh
Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Milestone
0.12.8dev

Comments

@srirambv
Copy link
Collaborator

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
1Password and LastPass repeated entries in right click context menu

Expected behavior:
Should only be shown once

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64

  • Brave Version:
    0.12.8 Preview 1

  • Steps to reproduce:

    1. Enable 1Password from preferences
    2. Right click shows two entries for 1Password in context menu
    3. Enable LastPass from preferences
    4. Right click shows three entries for 1Password in context menu

  • Screenshot if needed:
    image

  • Any related issues:
@srirambv srirambv added this to the 0.12.8dev milestone Oct 31, 2016
@darkdh darkdh self-assigned this Oct 31, 2016
darkdh added a commit that referenced this issue Oct 31, 2016
@darkdh
Undefined properties and nested folders handling
8970035 
fix #5291
fix #5293

Auditors: @bridiver, @bbondy

Test Plan:
1. Go to about:preferences#security
2. Select Lastpass as password manager
3. Login to Lastpass
4. Right click to show context menu
5. Nested menu of Lastpass should show
@darkdh darkdh mentioned this issue Oct 31, 2016
Merged
4 tasks
darkdh added a commit that referenced this issue Oct 31, 2016
@darkdh
Undefined properties and nested folders handling
64d594e 
fix #5291
fix #5293

requires brave/muon#85

Auditors: @bridiver, @bbondy

Test Plan:
1. Go to about:preferences#security
2. Select Lastpass as password manager
3. Login to Lastpass
4. Right click to show context menu
5. Nested menu of Lastpass should show
darkdh added a commit that referenced this issue Nov 1, 2016
@darkdh
Undefined properties and nested folders handling
6fb27a1 
fix #5291
fix #5293

requires brave/muon#85

Auditors: @bridiver, @bbondy

Test Plan:
1. Go to about:preferences#security
2. Select Lastpass as password manager
3. Login to Lastpass
4. Right click to show context menu
5. Nested menu of Lastpass should show
This was referenced Nov 2, 2016
Closed
Closed
Closed
This was referenced Nov 4, 2016
Closed
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Projects
None yet
Milestone
0.12.8dev
Development

Successfully merging a pull request may close this issue.

Undefined properties and nested folders handling brave/browser-laptop
5 participants
@bbondy @alexwykoff @luixxiul @darkdh @srirambv