Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixed YouTube.com player - updated ad blocking evasion #7432

Closed
lukemulks opened this issue Mar 1, 2017 · 3 comments
Closed

Fixed YouTube.com player - updated ad blocking evasion #7432

lukemulks opened this issue Mar 1, 2017 · 3 comments

Comments

@lukemulks
Copy link
Collaborator

lukemulks commented Mar 1, 2017

Test cases

  • Make sure automated tests are passing
    • npm run test -- --grep=isThirdPartyHost
    • npm run test -- --grep=adBlockUtil
  • Make sure things that used to be blocked are still being blocked.
  • Make sure you don't see ads on YouTube.

Original issue description

  • Did you search for similar issues before submitting this one?
    Yes - YT has updated the player enough times to where a fresh issue is needed.

  • Describe the issue you encountered:
    YT player has updated again, this time to evade ad blocking for both authenticated and unauthenticated users.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    All.

  • Brave Version (revision SHA):

Brave: 0.13.4 
rev: 71d8ffc7278a90b22b8617d37880787c1781e694 
Muon: 2.56.4 
libchromiumcontent: 56.0.2924.87 
V8: 5.6.326.50 
Node.js: 7.4.0 
Update Channel: dev 
os.platform: win32 
os.release: 10.0.14393 
os.arch: x64
  • Steps to reproduce:

    1. Go to YT
    2. Click segments
    3. Get ads
  • Actual result:
    Ads

  • Expected result:
    No Ads

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    Yes

  • Can this issue be consistently reproduced?
    Yes

Opening this issue to helps clear noise and clean-slate this process.

Troubleshooting and issue timeline for reference:

Original issue filed: #4693

  • This was resolved with v0.13.0 update, which disabled QUIC protocol.
  • Clearing cookies/cache resolved for residual issues.

02.10.2017 YT Player Update

02.27.2017 YT Update

  • @NejcZdovc @alexwykoff @echosa all report seeing ads in YT player regardless of authentication.
  • @srirambv files issue from other sites using embedded YT players, which only work when blocking is disabled.

Tracking the embedded YouTube iframe player issue here: #7428

Tracking the latest YouTube.com player issue from here #7432 .

Closed the other issues, as the overlap and history for them was confusing. All relevant issues are linked to this one I'm creating now. Let's update Youtube.com items here, and the embedded player issues on the linked issue from @srirambv above.

Next Steps:

  • Thorough investigation has taken place, several rounds since 02.10.2017.
  • Working within the adblock-lists repo to resolve with blocking rule updates.
  • Based on results from blocking list testing, additional measures may be required.
@lukemulks lukemulks changed the title YT player - updated ad blocking evasion YouTube.com player - updated ad blocking evasion Mar 1, 2017
@lukemulks lukemulks self-assigned this Mar 1, 2017
@srirambv
Copy link
Collaborator

srirambv commented Mar 3, 2017

YouTube Ads even without logging in. After playing 4 videos ad was seen on this link https://www.youtube.com/watch?v=V76psBrEypg
image
Ad's seem to come up when there is fingerprint script that is blocked
image

Without fingerprint
image

@bbondy bbondy closed this as completed in 85464b9 Mar 21, 2017
@bsclifton bsclifton added this to the 0.14.0 milestone Mar 21, 2017
@alexwykoff alexwykoff changed the title YouTube.com player - updated ad blocking evasion Fixed YouTube.com player - updated ad blocking evasion Mar 28, 2017
@quesada
Copy link

quesada commented Dec 16, 2017

I still see ads. Linux.

@quesada
Copy link

quesada commented Dec 16, 2017

Wow, youtube audio dies if switching tabs. Manjaro: aur/brave-bin 0.19.105-1 (92)
This is bad.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.