Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

fingerprinting brave via extension resources #8323

Closed
diracdeltas opened this issue Apr 14, 2017 · 2 comments · Fixed by #8325
Closed

fingerprinting brave via extension resources #8323

diracdeltas opened this issue Apr 14, 2017 · 2 comments · Fixed by #8325
Assignees
@diracdeltas
Labels
feature/shields QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.15.300 (Frozen,...

Comments

@diracdeltas
Copy link
Member

diracdeltas commented Apr 14, 2017 •
edited by luixxiul

Test plan

#8325 (comment)

https://extensions.inrialpes.fr/

seems like it should be blockable
@diracdeltas diracdeltas self-assigned this Apr 14, 2017
@diracdeltas diracdeltas added this to the 0.14.3 milestone Apr 14, 2017
diracdeltas added a commit that referenced this issue Apr 14, 2017
@diracdeltas
remove web_accessible_resources in bundled extensions
16d8c90 
fix #8323

Test Plan:
1. go to https://extensions.inrialpes.fr/ and test for installed extensions. it should report none.
2. go to https://www.qubes-os.org/downloads/ and download the torrent. it should redirect to webtorrent's page.
3. go to https://en.wikipedia.org/wiki/Magnet_URI_scheme and click any of the magnet links. it should redirect to webtorrent's page.
@diracdeltas diracdeltas mentioned this issue Apr 14, 2017
Merged
4 tasks
@diracdeltas diracdeltas mentioned this issue Apr 18, 2017
Closed
diracdeltas added a commit that referenced this issue Apr 26, 2017
@diracdeltas
remove web_accessible_resources in bundled extensions
66bc8ae 
fix #8323

Test Plan:
1. go to https://extensions.inrialpes.fr/ and test for installed extensions. it should report none.
2. go to https://www.qubes-os.org/downloads/ and download the torrent. it should redirect to webtorrent's page.
3. go to https://en.wikipedia.org/wiki/Magnet_URI_scheme and click any of the magnet links. it should redirect to webtorrent's page.
This was referenced May 2, 2017
Closed
Closed
Closed
Closed
@luixxiul
Copy link
Contributor

luixxiul commented May 3, 2017

CC @diracdeltas

  1. Enable LastPass
  2. Open https://extensions.inrialpes.fr/ and run test
  3. lastpass-free-password-ma is detected

If it is expected, please just reclose the issue.

@luixxiul luixxiul reopened this May 3, 2017
@diracdeltas
Copy link
Member Author

@luixxiul that is expected, we don't prevent fingerprinting all extensions, only the Brave-maintained ones.

This was referenced May 5, 2017
Closed
Closed
@jonathansampson jonathansampson mentioned this issue Jun 27, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@diracdeltas diracdeltas

Labels
feature/shields QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.15.300 (Frozen, only critical adds ...
Development

Successfully merging a pull request may close this issue.

remove web_accessible_resources in bundled extensions brave/browser-laptop
5 participants
@diracdeltas @alexwykoff @luixxiul @srirambv @cndouglas