Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Navigating to a PDF may crash the tab #8422

Closed
bbondy opened this issue Apr 21, 2017 · 3 comments · Fixed by brave/muon#189
Closed

Navigating to a PDF may crash the tab #8422

bbondy opened this issue Apr 21, 2017 · 3 comments · Fixed by brave/muon#189
Assignees
@darkdh
Labels
crash QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.15.1

Comments

@bbondy
Copy link
Member

bbondy commented Apr 21, 2017 •
edited by jonathansampson

  • Describe the issue you encountered:
    Navigating to a PDF may crash the active tab. It matters how you navigate to the PDF too; right-clicking the link and selecting Open in New Tab will not crash. A simple click of the link (to navigate within the active tab window) will cause the crash. PDF Viewer must be enabled.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    All

  • Brave Version (revision SHA):
    71fb730

  • Steps to reproduce:

  1. Click this link, https://pdfs.semanticscholar.org/2a01/e1f14172a91215931ed787d97dee1301fe7d.pdf

  • Actual result:
    Sad tab face

  • Expected result:
    Loads PDF

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    Yes

  • Can this issue be consistently reproduced?
    Yes
@bbondy bbondy added this to the 0.15.0 milestone Apr 21, 2017
@bbondy bbondy mentioned this issue Apr 21, 2017
Closed
74 tasks
@bbondy bbondy changed the title PDF jS crashes on linux PDF jS crashes on this particular pdf Apr 21, 2017
@bbondy bbondy removed this from the 0.15.0 milestone Apr 21, 2017
@jonathansampson jonathansampson changed the title PDF jS crashes on this particular pdf Navigating to a PDF may crash Brave Apr 28, 2017
@jonathansampson jonathansampson changed the title Navigating to a PDF may crash Brave Navigating to a PDF may crash the tab Apr 28, 2017
@jonathansampson jonathansampson added this to the 0.15.1 milestone Apr 28, 2017
@lukemulks
Copy link
Collaborator

Two additional data points:

  1. I was able to repro, windows 10, 64bit.

  2. We received a report from a contributor from the Brave Community today that also experienced the issue on macOS: https://community.brave.com/t/cannot-open-view-pdfs-after-latest-update-strange-error-screen-results/2444/1

@lukemulks
Copy link
Collaborator

We received an additional report from the Brave Community. Details and link included below for reference.

Community URL: https://community.brave.com/t/cannot-open-view-pdf-s-after-latest-update-strange-error-screen-results-help-me-apr-28-1-3-apr-28-1h-ago-herewego3h-i-have-macos-sierra-10-12-3-and-upgraded-to-brave-0-15-0-earlier-today-since-the-upgrade-when-i-click-to-download-or-view-a-pd/2450

Feedback:

Cannot open / view PDF’s after latest update - strange error screen results

Windows 7 64-bit user, and upgraded to Brave 0.15.0 earlier today. Since the upgrade, when I click to download or view a PDF, I will get a brief flash of the normal page structure for showing a PDF before the tab goes all black with the error image in the center, as in the attached screenshot

darkdh added a commit to brave/muon that referenced this issue Apr 28, 2017
@darkdh
Disble Isolate Extensions by default
382c92e 
This get turned on by default in
https://chromium.googlesource.com/chromium/src/+/9e1897b5c7dab9c190fc3c919a1c4662af63b3e6

fix brave/browser-laptop#8422

Auditors: @bridiver, @bbondy
@darkdh darkdh mentioned this issue Apr 28, 2017
Merged
@cndouglas
Copy link

I myself have seen this problem in 0.15.0. Thanks @darkdh!

@bbondy bbondy modified the milestones: 0.15.1, 0.15.2 Apr 29, 2017
@bbondy bbondy mentioned this issue Apr 30, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
crash QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.15.1
Development

Successfully merging a pull request may close this issue.

Disable Isolate Extensions by default brave/muon
7 participants
@jonathansampson @bbondy @alexwykoff @luixxiul @lukemulks @darkdh @cndouglas