Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

"Folder Upload" feature in Google Drive Broken #8601

Closed
KevDoy opened this issue May 1, 2017 · 7 comments · Fixed by brave/muon#361
Closed

"Folder Upload" feature in Google Drive Broken #8601

KevDoy opened this issue May 1, 2017 · 7 comments · Fixed by brave/muon#361
Assignees
@darkdh
Labels
hackday Legacy label for a one-day hack-session. muon QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include webcompat
Milestone
0.19.x Hotfix 13 ...

Comments

@KevDoy
Copy link

KevDoy commented May 1, 2017

  • Did you search for similar issues before submitting this one?
    Sure did.

  • Describe the issue you encountered:
    When choosing New, then Folder upload on Google Drive, I am able to find the folder in Finder. Let's say I chose a folder called "Files" inside of "Documents". Instead of creating and uploading the folder called "Files" it creates a folder named "Documents" and gives me an error message.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    macOS

  • Brave Version (revision SHA):
    ea5024d

  • Steps to reproduce:

    1. Open Google Drive & log in
    2. Press "New" Button
    3. Select "Folder Upload"
    4. Select a Folder to upload

  • Actual result:
    Error, wrong folder created

  • Expected result:
    Folder selected is uploaded to Google Drive

  • Is this an issue in the currently released version?
    Yes, and previous versions.

  • Can this issue be consistently reproduced?
    Yes it can.

  • Screenshot if needed:
    logos_-_google_drive

  • Any related issues:
    Not sure if this is opened, but Brave also has an issue download zipped files from Google Drive.
@bsclifton
Copy link
Member

I believe this requires the Google Drive extension to be installed

@jonathansampson do you know offhand?

@bsclifton bsclifton added the needs-info Another team member needs information from the PR/issue opener. label Jun 5, 2017
@luixxiul luixxiul mentioned this issue Sep 9, 2017
Merged
8 tasks
@darkdh
Copy link
Member

darkdh commented Sep 19, 2017

Will be fixed by brave/muon#242

@darkdh darkdh self-assigned this Oct 19, 2017
@darkdh darkdh added hackday Legacy label for a one-day hack-session. muon and removed needs-info Another team member needs information from the PR/issue opener. labels Oct 19, 2017
sydneyli pushed a commit to sydneyli/muon that referenced this issue Oct 19, 2017
Pull in file chooser from Chromium
9f136c3 
fix brave/browser-laptop#10666
fix brave/browser-laptop#8601

Auditors: @darkdh, @bbondy, @bsclifton, @bridiver
sydneyli pushed a commit to sydneyli/muon that referenced this issue Oct 19, 2017
Pull in file chooser from Chromium
2c1f33f 
fix brave/browser-laptop#10666
fix brave/browser-laptop#8601

Auditors: @darkdh, @bbondy, @bsclifton, @bridiver
@sydneyli sydneyli mentioned this issue Oct 19, 2017
Closed
bridiver pushed a commit to brave/muon that referenced this issue Oct 25, 2017
@bridiver
Pull in file chooser from Chromium
4a4d3de 
fix brave/browser-laptop#10666
fix brave/browser-laptop#8601

Auditors: @darkdh, @bbondy, @bsclifton, @bridiver
@bridiver bridiver mentioned this issue Oct 25, 2017
Merged
@luixxiul
Copy link
Contributor

On which build will brave/muon#361 be available? On 0.19.x?

@luixxiul luixxiul added needs-info Another team member needs information from the PR/issue opener. QA/test-plan-specified release-notes/include labels Oct 26, 2017
@darkdh
Copy link
Member

darkdh commented Oct 26, 2017

muon 4.6.0. Any branches upgrade to muon 4.6.0 will have the fix

@darkdh darkdh added this to the 0.20.x (Beta Channel) milestone Oct 26, 2017
@luixxiul luixxiul removed the needs-info Another team member needs information from the PR/issue opener. label Oct 26, 2017
@luixxiul
Copy link
Contributor

thanks!

This was referenced Dec 20, 2017
Closed
Closed
Closed
@srirambv
Copy link
Collaborator

Moving to 0.21.x since we aren't using Muon 4.6.x yet

@srirambv srirambv modified the milestones: 0.20.x (Beta Channel), 0.21.x (Developer Channel) Dec 22, 2017
@bsclifton bsclifton removed this from the 0.21.x (Developer Channel) milestone Jan 14, 2018
@bsclifton bsclifton added this to the 0.19.x Hotfix 13 milestone Jan 14, 2018
This was referenced Jan 15, 2018
Closed
Closed
Closed
@srirambv
Copy link
Collaborator

Verified. Works on Windows with both Fingerprint enabled and disabled.

@srirambv srirambv mentioned this issue Jan 17, 2018
Closed
@kjozwiak kjozwiak mentioned this issue Jan 19, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
hackday Legacy label for a one-day hack-session. muon QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include webcompat
Projects
None yet
Milestone
0.19.x Hotfix 13 (Release Channel)
Development

Successfully merging a pull request may close this issue.

use chromium file chooser brave/muon
Pull in file chooser from Chromium sydneyli/muon
6 participants
@kjozwiak @luixxiul @bsclifton @KevDoy @darkdh @srirambv